Refactor ESLint configuration. #21005

bardiharborow · 2016-10-25T13:54:00Z

In lieu of an official style guide, this takes the eslint:recommended preset, and then enables every ESLint rule that does not cause significant disruption to the codebase. It then disables the rules needed for js/tests to pass, as that follows a slightly different style. We may wish to tighten quite a bit of this later, but it's better than what we currently have.

This is one half of the fix for #20466, the other half being houndci/hound#889. This works towards #20740, but I suspect there is more to do, noting especially that ESLint does not cover all folders yet, as per #17924.

wolfy1339 · 2016-10-25T15:30:24Z

Hound uses the config found in the Bootstrap repo, not the new config you want to give it

Johann-S · 2016-10-26T07:55:16Z

I read a bit on HoundCi and I didn't found any options to lint differently JavaScript from js/tests/ folders unless to ignore them with .eslintignore see :
https://houndci.com/configuration#eslint
http://eslint.org/docs/user-guide/command-line-interface#ignoring-files-from-linting

But I don't understand why you said @bardiharborow ?

Travis will fail until #21003 is merged.

If we remove the PhantomJS Bridge nothing will change because of units tests will stay in ES5 and HoundJS will continue to warn us

bardiharborow · 2016-10-27T04:58:09Z

@Johann-S oh, that was just because js/tests/unit/phantom.js does not pass the new ESLint rules and I didn't fix it because I was going to get it removed.

I'm going to follow up with Hound and see if we can get Hound to use the recursive.eslintrc.json discovery strategy that ESLint uses by default.

mdo · 2016-11-01T03:37:58Z

Have some conflicts here now.

I'm unsure where this and #21003 lie, so @bardiharborow and @Johann-S, I defer to you two on what get's merged when :). Happy to chat more over Slack if it'd help btw.

houndci-bot · 2016-11-01T10:27:54Z

js/tests/unit/tooltip.js

    assert.expect(41)
    var $el = $('<button>Trigger</button>')
      .appendTo('#qunit-fixture')
      .bootstrapTooltip({ trigger: 'click hover focus', animation: false })
    var tooltip = $el.data('bs.tooltip')
    var $tooltip = $(tooltip.getTipElement())

-    function showingTooltip() { return $tooltip.hasClass('active') || tooltip._hoverState == 'active' }
+    function showingTooltip() { return $tooltip.hasClass('active') || tooltip._hoverState === 'active' }


Statement inside of curly braces should be on next line brace-style
This line has 2 statements. Maximum allowed is 1 max-statements-per-line
Closing curly brace should be on the same line as opening curly brace or on the line after the previous block brace-style

houndci-bot · 2016-11-01T23:25:32Z

js/tests/unit/tooltip.js

@@ -608,7 +608,7 @@ $(function () {

    var $tooltip = $('<a href="#" rel="tooltip" title="Another tooltip"/>')
      .appendTo('#qunit-fixture')
-      .bootstrapTooltip({ delay: { show: 0, hide: 150 }})
+      .bootstrapTooltip({ delay: { show: 0, hide: 150 } })


Expected a line break after this opening brace object-curly-newline
Object properties must go on a new line object-property-newline
Expected a line break before this closing brace object-curly-newline

houndci-bot · 2016-11-01T23:25:32Z

js/tests/unit/tooltip.js

@@ -587,7 +587,7 @@ $(function () {

    var $tooltip = $('<a href="#" rel="tooltip" title="Another tooltip"/>')
      .appendTo('#qunit-fixture')
-      .bootstrapTooltip({ delay: { show: 150, hide: 0 }})
+      .bootstrapTooltip({ delay: { show: 150, hide: 0 } })


Expected a line break after this opening brace object-curly-newline
Object properties must go on a new line object-property-newline
Expected a line break before this closing brace object-curly-newline

houndci-bot · 2016-11-01T23:25:32Z

js/tests/unit/tooltip.js

@@ -540,7 +540,7 @@ $(function () {

    var $tooltip = $('<a href="#" rel="tooltip" title="Another tooltip"/>')
      .appendTo('#qunit-fixture')
-      .bootstrapTooltip({ delay: { show: 0, hide: 150 }})
+      .bootstrapTooltip({ delay: { show: 0, hide: 150 } })


Expected a line break after this opening brace object-curly-newline
Object properties must go on a new line object-property-newline
Expected a line break before this closing brace object-curly-newline

houndci-bot · 2016-11-01T23:25:33Z

js/tests/unit/tooltip.js

@@ -382,7 +382,7 @@ $(function () {
    var $tooltip = $($target.data('bs.tooltip').tip)

    // this is some dumb hack stuff because sub pixels in firefox
-    var top = Math.round($target.offset().top + ($target[0].offsetHeight / 2) - ($tooltip[0].offsetHeight / 2))
+    var top = Math.round($target.offset().top + $target[0].offsetHeight / 2 - $tooltip[0].offsetHeight / 2)


All 'var' declarations must be at the top of the function scope vars-on-top
Unexpected var, use let or const instead no-var
No magic number: 2 no-magic-numbers

houndci-bot · 2016-11-01T23:25:33Z

js/tests/unit/tooltip.js

@@ -1,5 +1,5 @@
 $(function () {
-  'use strict';
+  'use strict'


'use strict' is unnecessary inside of modules strict

houndci-bot · 2016-11-01T23:25:33Z

js/tests/unit/tab.js

@@ -1,5 +1,5 @@
 $(function () {
-  'use strict';
+  'use strict'


'use strict' is unnecessary inside of modules strict

houndci-bot · 2016-11-01T23:25:33Z

js/tests/unit/scrollspy.js

-      if (type === 'js') $content.bootstrapScrollspy({ target: '.navbar', offset: 0, method: 'position' })
-      else if (type === 'data') $(window).trigger('load')
+      if (type === 'js') { $content.bootstrapScrollspy({ target: '.navbar', offset: 0, method: 'position' }) }
+      else if (type === 'data') { $(window).trigger('load') }


Closing curly brace does not appear on the same line as the subsequent block brace-style
This line has 2 statements. Maximum allowed is 1 max-statements-per-line
Closing curly brace should be on the same line as opening curly brace or on the line after the previous block brace-style
Statement inside of curly braces should be on next line brace-style

houndci-bot · 2016-11-01T23:25:33Z

js/tests/unit/scrollspy.js

@@ -399,8 +402,8 @@ $(function () {
      $navbar.appendTo('#qunit-fixture')
      $content.appendTo('#qunit-fixture')

-      if (type === 'js') $content.bootstrapScrollspy({ target: '.navbar', offset: 0, method: 'position' })
-      else if (type === 'data') $(window).trigger('load')
+      if (type === 'js') { $content.bootstrapScrollspy({ target: '.navbar', offset: 0, method: 'position' }) }


This line has 2 statements. Maximum allowed is 1 max-statements-per-line
Statement inside of curly braces should be on next line brace-style
Closing curly brace should be on the same line as opening curly brace or on the line after the previous block brace-style
Expected a line break after this opening brace object-curly-newline
Object properties must go on a new line object-property-newline
Expected a line break before this closing brace object-curly-newline

houndci-bot · 2016-11-01T23:25:34Z

js/tests/unit/scrollspy.js

-    !function testActiveElements() {
-      if (++times > 3) return done()
+    function testActiveElements() {
+      if (++times > 3) { return done() }


No magic number: 3 no-magic-numbers
This line has 2 statements. Maximum allowed is 1 max-statements-per-line
Closing curly brace should be on the same line as opening curly brace or on the line after the previous block brace-style
Statement inside of curly braces should be on next line brace-style

houndci-bot · 2016-11-01T23:25:34Z

js/tests/unit/scrollspy.js

@@ -231,8 +231,8 @@ $(function () {
      .appendTo('#qunit-fixture')
      .bootstrapScrollspy({ offset: 0, target: '#navigation' })

-    !function testActiveElements() {
-      if (++times > 3) return done()
+    function testActiveElements() {


Expected to return a value at the end of this function consistent-return

houndci-bot · 2016-11-01T23:25:34Z

js/tests/unit/scrollspy.js

@@ -1,5 +1,5 @@
 $(function () {
-  'use strict';
+  'use strict'


'use strict' is unnecessary inside of modules strict

houndci-bot · 2016-11-01T23:25:34Z

js/tests/unit/popover.js

@@ -1,5 +1,5 @@
 $(function () {
-  'use strict';
+  'use strict'


'use strict' is unnecessary inside of modules strict

houndci-bot · 2016-11-01T23:25:35Z

js/tests/unit/phantom.js

@@ -7,7 +7,7 @@
 */

 (function () {
-  'use strict';
+  'use strict'


'use strict' is unnecessary inside of modules strict

houndci-bot · 2016-11-01T23:25:35Z

js/tests/unit/modal.js

@@ -1,5 +1,5 @@
 $(function () {
-  'use strict';
+  'use strict'


'use strict' is unnecessary inside of modules strict

houndci-bot · 2016-11-01T23:25:35Z

js/tests/unit/dropdown.js

@@ -1,5 +1,5 @@
 $(function () {
-  'use strict';
+  'use strict'


'use strict' is unnecessary inside of modules strict

Johann-S · 2016-11-02T06:16:23Z

~~Just a question @bardiharborow is it still possible to run QUnit tests in a web browser with your PR ? Or we have to build the tests into ES5 with Babel~~

EDIT :
Forget my question every thing is fine here 👍

bardiharborow · 2016-11-04T02:23:35Z

@mdo, we're good to go here. Travis is green. :)

houndci-bot · 2016-11-08T13:07:39Z

js/tests/unit/tooltip.js

@@ -608,7 +608,7 @@ $(function () {

    var $tooltip = $('<a href="#" rel="tooltip" title="Another tooltip"/>')
      .appendTo('#qunit-fixture')
-      .bootstrapTooltip({ delay: { show: 0, hide: 150 }})
+      .bootstrapTooltip({ delay: { show: 0, hide: 150 } })


Expected a line break after this opening brace object-curly-newline
Object properties must go on a new line object-property-newline
Expected a line break before this closing brace object-curly-newline

houndci-bot · 2016-11-24T01:05:00Z

js/tests/unit/tooltip.js

@@ -540,7 +540,7 @@ $(function () {

    var $tooltip = $('<a href="#" rel="tooltip" title="Another tooltip"/>')
      .appendTo('#qunit-fixture')
-      .bootstrapTooltip({ delay: { show: 0, hide: 150 }})
+      .bootstrapTooltip({ delay: { show: 0, hide: 150 } })


Expected a line break after this opening brace object-curly-newline
Object properties must go on a new line object-property-newline
Expected a line break before this closing brace object-curly-newline

houndci-bot · 2016-11-24T01:05:01Z

js/tests/unit/tooltip.js

@@ -540,7 +540,7 @@ $(function () {

    var $tooltip = $('<a href="#" rel="tooltip" title="Another tooltip"/>')
      .appendTo('#qunit-fixture')
-      .bootstrapTooltip({ delay: { show: 0, hide: 150 }})
+      .bootstrapTooltip({ delay: { show: 0, hide: 150 } })


Expected a line break after this opening brace object-curly-newline
Object properties must go on a new line object-property-newline
Expected a line break before this closing brace object-curly-newline

houndci-bot · 2016-11-24T01:05:01Z

js/tests/unit/tooltip.js

@@ -382,7 +382,7 @@ $(function () {
    var $tooltip = $($target.data('bs.tooltip').tip)

    // this is some dumb hack stuff because sub pixels in firefox
-    var top = Math.round($target.offset().top + ($target[0].offsetHeight / 2) - ($tooltip[0].offsetHeight / 2))
+    var top = Math.round($target.offset().top + $target[0].offsetHeight / 2 - $tooltip[0].offsetHeight / 2)


All 'var' declarations must be at the top of the function scope vars-on-top
Unexpected var, use let or const instead no-var
No magic number: 2 no-magic-numbers

houndci-bot · 2016-11-24T01:05:01Z

js/tests/unit/tooltip.js

@@ -382,7 +382,7 @@ $(function () {
    var $tooltip = $($target.data('bs.tooltip').tip)

    // this is some dumb hack stuff because sub pixels in firefox
-    var top = Math.round($target.offset().top + ($target[0].offsetHeight / 2) - ($tooltip[0].offsetHeight / 2))
+    var top = Math.round($target.offset().top + $target[0].offsetHeight / 2 - $tooltip[0].offsetHeight / 2)


All 'var' declarations must be at the top of the function scope vars-on-top
Unexpected var, use let or const instead no-var
No magic number: 2 no-magic-numbers

houndci-bot · 2016-11-24T01:05:01Z

js/tests/unit/tooltip.js

@@ -1,5 +1,5 @@
 $(function () {
-  'use strict';
+  'use strict'


'use strict' is unnecessary inside of modules strict

houndci-bot · 2016-11-24T01:05:01Z

js/tests/unit/tooltip.js

@@ -1,5 +1,5 @@
 $(function () {
-  'use strict';
+  'use strict'


'use strict' is unnecessary inside of modules strict

houndci-bot · 2016-11-24T01:05:01Z

js/tests/unit/tab.js

@@ -1,5 +1,5 @@
 $(function () {
-  'use strict';
+  'use strict'


'use strict' is unnecessary inside of modules strict

houndci-bot · 2016-11-24T01:05:02Z

js/tests/unit/tab.js

@@ -1,5 +1,5 @@
 $(function () {
-  'use strict';
+  'use strict'


'use strict' is unnecessary inside of modules strict

houndci-bot · 2016-11-24T01:05:02Z

js/tests/unit/scrollspy.js

-      if (type === 'js') $content.bootstrapScrollspy({ target: '.navbar', offset: 0, method: 'position' })
-      else if (type === 'data') $(window).trigger('load')
+      if (type === 'js') { $content.bootstrapScrollspy({ target: '.navbar', offset: 0, method: 'position' }) }
+      else if (type === 'data') { $(window).trigger('load') }


Closing curly brace does not appear on the same line as the subsequent block brace-style
This line has 2 statements. Maximum allowed is 1 max-statements-per-line
Closing curly brace should be on the same line as opening curly brace or on the line after the previous block brace-style
Statement inside of curly braces should be on next line brace-style

houndci-bot · 2016-11-24T01:05:02Z

js/tests/unit/scrollspy.js

-      if (type === 'js') $content.bootstrapScrollspy({ target: '.navbar', offset: 0, method: 'position' })
-      else if (type === 'data') $(window).trigger('load')
+      if (type === 'js') { $content.bootstrapScrollspy({ target: '.navbar', offset: 0, method: 'position' }) }
+      else if (type === 'data') { $(window).trigger('load') }


Closing curly brace does not appear on the same line as the subsequent block brace-style
This line has 2 statements. Maximum allowed is 1 max-statements-per-line
Closing curly brace should be on the same line as opening curly brace or on the line after the previous block brace-style
Statement inside of curly braces should be on next line brace-style

houndci-bot · 2016-11-24T01:05:02Z

js/tests/unit/scrollspy.js

@@ -399,8 +401,8 @@ $(function () {
      $navbar.appendTo('#qunit-fixture')
      $content.appendTo('#qunit-fixture')

-      if (type === 'js') $content.bootstrapScrollspy({ target: '.navbar', offset: 0, method: 'position' })
-      else if (type === 'data') $(window).trigger('load')
+      if (type === 'js') { $content.bootstrapScrollspy({ target: '.navbar', offset: 0, method: 'position' }) }


This line has 2 statements. Maximum allowed is 1 max-statements-per-line
Statement inside of curly braces should be on next line brace-style
Closing curly brace should be on the same line as opening curly brace or on the line after the previous block brace-style
Expected a line break after this opening brace object-curly-newline
Object properties must go on a new line object-property-newline
Expected a line break before this closing brace object-curly-newline

houndci-bot · 2016-11-24T01:05:02Z

js/tests/unit/scrollspy.js

@@ -399,8 +401,8 @@ $(function () {
      $navbar.appendTo('#qunit-fixture')
      $content.appendTo('#qunit-fixture')

-      if (type === 'js') $content.bootstrapScrollspy({ target: '.navbar', offset: 0, method: 'position' })
-      else if (type === 'data') $(window).trigger('load')
+      if (type === 'js') { $content.bootstrapScrollspy({ target: '.navbar', offset: 0, method: 'position' }) }


This line has 2 statements. Maximum allowed is 1 max-statements-per-line
Statement inside of curly braces should be on next line brace-style
Closing curly brace should be on the same line as opening curly brace or on the line after the previous block brace-style
Expected a line break after this opening brace object-curly-newline
Object properties must go on a new line object-property-newline
Expected a line break before this closing brace object-curly-newline

houndci-bot · 2016-11-24T01:05:02Z

js/tests/unit/scrollspy.js

-    !function testActiveElements() {
-      if (++times > 3) return done()
+    function testActiveElements() {
+      if (++times > 3) { return done() }


No magic number: 3 no-magic-numbers
This line has 2 statements. Maximum allowed is 1 max-statements-per-line
Closing curly brace should be on the same line as opening curly brace or on the line after the previous block brace-style
Statement inside of curly braces should be on next line brace-style

houndci-bot · 2016-11-24T01:05:02Z

js/tests/unit/scrollspy.js

-    !function testActiveElements() {
-      if (++times > 3) return done()
+    function testActiveElements() {
+      if (++times > 3) { return done() }


No magic number: 3 no-magic-numbers
This line has 2 statements. Maximum allowed is 1 max-statements-per-line
Closing curly brace should be on the same line as opening curly brace or on the line after the previous block brace-style
Statement inside of curly braces should be on next line brace-style

houndci-bot · 2016-11-24T01:05:03Z

js/tests/unit/scrollspy.js

@@ -231,8 +231,8 @@ $(function () {
      .appendTo('#qunit-fixture')
      .bootstrapScrollspy({ offset: 0, target: '#navigation' })

-    !function testActiveElements() {
-      if (++times > 3) return done()
+    function testActiveElements() {


Expected to return a value at the end of this function consistent-return

houndci-bot · 2016-11-24T01:05:03Z

js/tests/unit/scrollspy.js

@@ -231,8 +231,8 @@ $(function () {
      .appendTo('#qunit-fixture')
      .bootstrapScrollspy({ offset: 0, target: '#navigation' })

-    !function testActiveElements() {
-      if (++times > 3) return done()
+    function testActiveElements() {


Expected to return a value at the end of this function consistent-return

houndci-bot · 2016-11-24T01:05:03Z

js/tests/unit/scrollspy.js

@@ -1,5 +1,5 @@
 $(function () {
-  'use strict';
+  'use strict'


'use strict' is unnecessary inside of modules strict

houndci-bot · 2016-11-24T01:05:03Z

js/tests/unit/scrollspy.js

@@ -1,5 +1,5 @@
 $(function () {
-  'use strict';
+  'use strict'


'use strict' is unnecessary inside of modules strict

houndci-bot · 2016-11-24T01:05:03Z

js/tests/unit/popover.js

@@ -1,5 +1,5 @@
 $(function () {
-  'use strict';
+  'use strict'


'use strict' is unnecessary inside of modules strict

houndci-bot · 2016-11-24T01:05:03Z

js/tests/unit/popover.js

@@ -1,5 +1,5 @@
 $(function () {
-  'use strict';
+  'use strict'


'use strict' is unnecessary inside of modules strict

houndci-bot · 2016-11-24T01:05:03Z

js/tests/unit/phantom.js

@@ -7,7 +7,7 @@
 */

 (function () {
-  'use strict';
+  'use strict'


'use strict' is unnecessary inside of modules strict

houndci-bot · 2016-11-24T01:05:03Z

js/tests/unit/phantom.js

@@ -7,7 +7,7 @@
 */

 (function () {
-  'use strict';
+  'use strict'


'use strict' is unnecessary inside of modules strict

houndci-bot · 2016-11-24T01:05:04Z

js/tests/unit/modal.js

@@ -1,5 +1,5 @@
 $(function () {
-  'use strict';
+  'use strict'


'use strict' is unnecessary inside of modules strict

houndci-bot · 2016-11-24T01:05:04Z

js/tests/unit/modal.js

@@ -1,5 +1,5 @@
 $(function () {
-  'use strict';
+  'use strict'


'use strict' is unnecessary inside of modules strict

houndci-bot · 2016-11-24T01:05:04Z

js/tests/unit/dropdown.js

@@ -1,5 +1,5 @@
 $(function () {
-  'use strict';
+  'use strict'


'use strict' is unnecessary inside of modules strict

houndci-bot · 2016-11-24T01:05:04Z

js/tests/unit/dropdown.js

@@ -1,5 +1,5 @@
 $(function () {
-  'use strict';
+  'use strict'


'use strict' is unnecessary inside of modules strict

mdo · 2016-11-25T23:01:29Z

Had a small conflict from merging #17642, but I think I fixed it right up. Merged! Thanks so much <3.

mdo added js v4 labels Oct 26, 2016

mdo modified the milestone: v4.0.0-alpha.6 Oct 26, 2016

This was referenced Oct 27, 2016

ESLint configuration with cascading/hierarchy houndci/hound#1210

Closed

v4 - Unification JS style in _jQueryInterface #17531

Closed

houndci-bot reviewed Nov 1, 2016

View reviewed changes

Johann-S mentioned this pull request Nov 1, 2016

Closes #21055: Prevents ScrollSpy from clearing item when Safari rubberbands #21056

Merged

houndci-bot reviewed Nov 1, 2016

View reviewed changes

js/tests/unit/tooltip.js

@@ -1,5 +1,5 @@

$(function () {

'use strict';

'use strict'

Copy link

houndci-bot Nov 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'use strict' is unnecessary inside of modules strict

houndci-bot reviewed Nov 1, 2016

View reviewed changes

js/tests/unit/tab.js

@@ -1,5 +1,5 @@

$(function () {

'use strict';

'use strict'

Copy link

houndci-bot Nov 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'use strict' is unnecessary inside of modules strict

houndci-bot reviewed Nov 1, 2016

View reviewed changes

js/tests/unit/popover.js

@@ -1,5 +1,5 @@

$(function () {

'use strict';

'use strict'

Copy link

houndci-bot Nov 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'use strict' is unnecessary inside of modules strict

houndci-bot reviewed Nov 1, 2016

View reviewed changes

js/tests/unit/modal.js

@@ -1,5 +1,5 @@

$(function () {

'use strict';

'use strict'

Copy link

houndci-bot Nov 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'use strict' is unnecessary inside of modules strict

houndci-bot reviewed Nov 1, 2016

View reviewed changes

houndci-bot reviewed Nov 8, 2016

View reviewed changes

houndci-bot reviewed Nov 24, 2016

View reviewed changes

js/tests/unit/tab.js

@@ -1,5 +1,5 @@

$(function () {

'use strict';

'use strict'

Copy link

houndci-bot Nov 24, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'use strict' is unnecessary inside of modules strict

houndci-bot reviewed Nov 24, 2016

View reviewed changes

js/tests/unit/tab.js

@@ -1,5 +1,5 @@

$(function () {

'use strict';

'use strict'

Copy link

houndci-bot Nov 24, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'use strict' is unnecessary inside of modules strict

houndci-bot reviewed Nov 24, 2016

View reviewed changes

js/tests/unit/modal.js

@@ -1,5 +1,5 @@

$(function () {

'use strict';

'use strict'

Copy link

houndci-bot Nov 24, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'use strict' is unnecessary inside of modules strict

houndci-bot reviewed Nov 24, 2016

View reviewed changes

js/tests/unit/modal.js

@@ -1,5 +1,5 @@

$(function () {

'use strict';

'use strict'

Copy link

houndci-bot Nov 24, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'use strict' is unnecessary inside of modules strict

houndci-bot reviewed Nov 24, 2016

View reviewed changes

mdo merged commit c2616fb into twbs:v4-dev Nov 25, 2016

mdo mentioned this pull request Nov 25, 2016

v4 Alpha 6 ship list #20939

Closed

bardiharborow deleted the eslint branch November 26, 2016 03:50

Refactor ESLint configuration. #21005

Refactor ESLint configuration. #21005

Conversation

bardiharborow commented Oct 25, 2016 • edited

wolfy1339 commented Oct 25, 2016

Johann-S commented Oct 26, 2016

bardiharborow commented Oct 27, 2016 • edited

mdo commented Nov 1, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Johann-S commented Nov 2, 2016 • edited

bardiharborow commented Nov 4, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mdo commented Nov 25, 2016

bardiharborow commented Oct 25, 2016 •

edited

bardiharborow commented Oct 27, 2016 •

edited

Johann-S commented Nov 2, 2016 •

edited