Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port v4 browser support table format to v3 #19273

Merged
merged 1 commit into from Feb 28, 2016
Merged

Port v4 browser support table format to v3 #19273

merged 1 commit into from Feb 28, 2016

Conversation

patrickhlauke
Copy link
Member

Port of #18614 from v4 to v3

Ref #19269

@patrickhlauke
Copy link
Member Author

/cc @cvrebert @mdo

@patrickhlauke
Copy link
Member Author

@mdo @cvrebert thoughts on this? I note that the v4 tables included Android browser/ webview, while the v3 table didn't. That's my only concern here (the rest should be fairly non-controversial)

<td class="text-muted">N/A</td>
<td class="text-success"><span class="glyphicon glyphicon-ok" aria-hidden="true"></span> Supported</td>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should read "Android v5.0+ supported" to match v4

@cvrebert
Copy link
Collaborator

If we're going to claim support for Edge, then we should add Edge to v3's Sauce testing config.

I slightly question adding the "feature" of AndroidBrowser+Edge+Win10Mobile official support this late in v3's lifecycle though.

@patrickhlauke
Copy link
Member Author

Fair enough about not adding new browser combos. As an alternative, then, how about just porting the top/tail text, split into mobile/desktop, but leave actual table content unchanged?

@mdo
Copy link
Member

mdo commented Feb 27, 2016

Fair enough about not adding new browser combos. As an alternative, then, how about just porting the top/tail text, split into mobile/desktop, but leave actual table content unchanged?

Updated table layout and more granular text is a-okay by me. I'd rather not sign us up for more/new browser combos as @cvrebert mentioned :).

@cvrebert
Copy link
Collaborator

As an alternative, then, how about just porting the top/tail text, split into mobile/desktop, but leave actual table content unchanged?

👍

@patrickhlauke
Copy link
Member Author

rejigged the PR - this now ports the overall formatting, splitting the support table into separate mobile/desktop, but does not add any new browser combos (although I did add Microsoft Edge under the "Unofficially..." section, as from my experience it seems to all work fairly well there). Also, as Opera now falls under the "Alternative browsers which use the latest version of WebKit, Blink, or Gecko," bit, I removed it from the tables as well.

For a quick look of the end result of this, see http://www.bootply.com/oFgjmGsVGX

@patrickhlauke patrickhlauke added this to the v3.3.7 milestone Feb 27, 2016
@patrickhlauke patrickhlauke changed the title Port v4 browser support tables to v3 Port v4 browser support table format to v3 Feb 28, 2016
patrickhlauke added a commit that referenced this pull request Feb 28, 2016
@patrickhlauke patrickhlauke merged commit 85c3cf1 into twbs:master Feb 28, 2016
@mdo mdo mentioned this pull request Feb 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants