have the deep nested proxy work with explain

testdouble · Feb 4, 2019 · 247b673 · 247b673
1 parent d7418d9
commit 247b673
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 6 deletions.
diff --git a/src/explain.js b/src/explain.js
@@ -27,13 +27,22 @@ function explainObject (obj) {
   }
 }
 
+const forbidden = ['length', 'name', 'prototype']
 function explainChildren (thing) {
   const explanations = []
-  const children = _.cloneDeepWith(thing, (val, key, obj, stack) => {
-    if (_.isFunction(val) && stack) {
-      return _.tap(explainFunction(val), (explanation) => {
+  const children = {}
+
+  Object.getOwnPropertyNames(thing).forEach((propName) => {
+    if (_.isFunction(thing[propName])) {
+      children[propName] = _.tap(explainFunction(thing[propName]), explanation => {
         if (explanation.isTestDouble) explanations.push(explanation)
       })
+    } else if (!forbidden.includes(propName) && _.isObject(thing[propName])) {
+      const explained = explainChildren(thing[propName])
+      children[propName] = explained.children
+      explanations.push(...explained.explanations)
+    } else if (!forbidden.includes(propName)) {
+      children[propName] = thing[propName]
     }
   })
   return { explanations, children }

diff --git a/src/object/proxy.ts b/src/object/proxy.ts
@@ -2,6 +2,7 @@ import * as theredoc from 'theredoc'
 import _ from '../wrap/lodash'
 import log from '../log'
 import tdFunction from '../function'
+import store from '../store'
 
 export default function proxy<T> (name: string, { excludeMethods } : { excludeMethods?: string[] } = {}) : T {
   ensureProxySupport(name)
@@ -31,7 +32,10 @@ const generateHandler = (internalName, excludeMethods) => ({
 const generateGet = (target, propKey, internalName, excludeMethods) => {
   if (!target.hasOwnProperty(propKey) && !_.includes(excludeMethods, propKey)) {
     const nameWithProp = `${internalName || ''}.${String(propKey)}`
-    target[propKey] = new Proxy(tdFunction(nameWithProp), generateHandler(nameWithProp, excludeMethods))
+    const tdFunc = tdFunction(nameWithProp)
+    const tdFuncProxy = new Proxy(tdFunc, generateHandler(nameWithProp, excludeMethods))
+    store.registerAlias(tdFunc, tdFuncProxy)
+    target[propKey] = tdFuncProxy
   }
   return target[propKey]
 }
diff --git a/src/store/index.js b/src/store/index.js
@@ -4,7 +4,7 @@ import { EventEmitter } from 'events'
 const storeEmitter = new EventEmitter()
 let globalStore = []
 
-export default {
+const store = {
   onReset (func) {
     storeEmitter.on('reset', func)
   },
@@ -15,7 +15,7 @@ export default {
   },
 
   for (testDouble, createIfNew = true) {
-    const entry = _.find(globalStore, { testDouble })
+    const entry = _.find(globalStore, e => testDouble === e.testDouble || testDouble === e.alias)
     if (entry) {
       return entry
     } else if (createIfNew) {
@@ -28,5 +28,10 @@ export default {
         return globalStore.push(newEntry)
       })
     }
+  },
+  registerAlias (testDouble, alias) {
+    store.for(testDouble).alias = alias
   }
 }
+
+export default store