Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignoreFontFamilies option to font-family-no-missing-generic-family-keyword #4656

Merged
merged 6 commits into from Apr 3, 2020

Conversation

mattfelten
Copy link
Contributor

Which issue, if any, is this issue related to?

Closes #3288

Is there anything in the PR that needs further explanation?

Seems to work alright so far. Something I'm struggling with is how a font family name in quotes should be written. I couldn't tell if that works and I'm just writing the test poorly or this doesn't work with quoted names.

Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattfelten Thank you for your pull request!

I now realise that the option should be called ignoreFontFamilies as value is ambiguous and does not take into account font families within the value of the font shorthand property. Can you update the pull request to reflect this, please?

I've also requested a couple of other changes to bring the option in line with those in other rules.

@jeddy3 jeddy3 changed the title Add ignoreValues option to font-family-no-missing-generic-family-keyword Add ignoreFontFamilies option to font-family-no-missing-generic-family-keyword Mar 26, 2020
@mattfelten
Copy link
Contributor Author

@jeddy3 Thanks for the review. Just made the requested changes. Let me know if I can make this better any more.

Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattfelten Thanks for making the amends. It's looking good!

I've made two more, very minor, requests.

@mattfelten
Copy link
Contributor Author

@jeddy3 Thanks! Got those taken care of too

Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattfelten Thanks for making the changes so promptly. For some reason, I didn't get a notification so I'm only just looking now.

We'll make sure this gets into our next pending release.

Thanks again!

@jeddy3 jeddy3 mentioned this pull request Apr 2, 2020
6 tasks
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some typos and suggest one on the rule document.

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[suggestion] Is it reasonable to add test cases for regex?

@mattfelten
Copy link
Contributor Author

Thanks @jeddy3 !

@ybiquitous I got your changes in. Thanks for looking! Lmk if I can improve anything else.

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!👍

@jeddy3 jeddy3 merged commit 90f72ab into stylelint:master Apr 3, 2020
@jeddy3
Copy link
Member

jeddy3 commented Apr 3, 2020

Changelog:

  • Added: ignoreFontFamilies: [] to font-family-no-missing-generic-family-keyword (#4656).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add ignoreFontFamilies: [] to font-family-no-missing-generic-family-keyword
3 participants