Fix false positives for focus-visible in selector-pseudo-class-no-unknown #3887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pseudo class is part of the CSS Level 4 Selector Working Draft: https://www.w3.org/TR/selectors-4/#the-focus-visible-pseudo
|
I figured out why the test wasn't working, I had accidentally put it into the pseudo element test file and not the pseudo class test file. That's the fixed in the latest version (sha1 251f038) that I just pushed. |
gucong3000
approved these changes
Jan 16, 2019
jeddy3
changed the title
|
Changelog:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is one known issue with this PR: the test passes even if the fix itself is reverted. Any ideas why?
Fixes: #3886