Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run rules for each root of document #3875

Merged
merged 2 commits into from Jan 12, 2019
Merged

Run rules for each root of document #3875

merged 2 commits into from Jan 12, 2019

Conversation

gucong3000
Copy link
Member

Which issue, if any, is this issue related to?

Closes #3862 #3863

Is there anything in the PR that needs further explanation?

"No, it's self explanatory."

@gucong3000 gucong3000 mentioned this pull request Jan 4, 2019
Closed
hudochenkov
hudochenkov approved these changes Jan 10, 2019
View reviewed changes
Copy link
Member

@hudochenkov hudochenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Thank you!

I've added tests for mentioned CSS-in-JS issues.

jeddy3
jeddy3 approved these changes Jan 12, 2019
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jeddy3 jeddy3 merged commit e57e893 into master Jan 12, 2019
@jeddy3 jeddy3 deleted the each_root branch January 12, 2019 14:07
@jeddy3
Copy link
Member

jeddy3 commented Jan 12, 2019

  • Fixed: no-descending-specificity false positives for styled-components (#3875).
  • Fixed: no-duplicate-selectors false positives for styled-components (#3875).

@jeddy3 jeddy3 mentioned this pull request Jan 12, 2019
Closed
@vladfaust
Copy link

Thank you! ❤️

@ark120202 ark120202 mentioned this pull request Jan 28, 2019
Closed
@jeddy3 jeddy3 mentioned this pull request Feb 21, 2019
Closed
@snyk-bot snyk-bot mentioned this pull request Sep 23, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hudochenkov hudochenkov hudochenkov approved these changes

@jeddy3 jeddy3 jeddy3 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix false positives for styled-components in no-descending-specificity
4 participants
@gucong3000 @jeddy3 @vladfaust @hudochenkov