New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove postcss-styled
#3872
Remove postcss-styled
#3872
Conversation
0865a53
to
f7b026c
Compare
@gucong3000 I need a little help understanding this PR. Has At the moment (Incidentally, the error message in that last link needs to be updated...) |
dd054ce
to
ec20633
Compare
I updated the code. |
I think it would make sense to add deprecation notice for Also, I think we should rename |
Should I make any changes to this PR? |
SGTM.
I'd be happy to see the suggestion above rolled into this PR. It'd be great if there was just a "css-in-js"|"html"|"less"|"markdown"|"sass"|"scss"|"sugarss" |
ec20633
to
9590958
Compare
9590958
to
49eeb50
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @gucong3000!
I think deprecation notice better to do in another PR to have things more clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gucong3000 Excellent.
I think deprecation notice better to do in another PR to have things more clear.
SGTM.
|
No description provided.