Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignore: ["next-sibling"] to selector-max-type #3832

Merged
merged 6 commits into from Jan 3, 2019

Conversation

iliyaZelenko
Copy link
Member

Which issue, if any, is this issue related to?

Closes #3757

Is there anything in the PR that needs further explanation?

"No, it's self explanatory."

Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iliyaZelenko Thanks!

I've requested a few changes (some using the new "Suggested change" feature).

lib/rules/selector-max-type/__tests__/index.js Outdated Show resolved Hide resolved
lib/rules/selector-max-type/__tests__/index.js Outdated Show resolved Hide resolved
lib/rules/selector-max-type/__tests__/index.js Outdated Show resolved Hide resolved
lib/rules/selector-max-type/__tests__/index.js Outdated Show resolved Hide resolved
lib/rules/selector-max-type/index.js Show resolved Hide resolved
@jeddy3 jeddy3 changed the title selector-max-type rule, ignore: ["next-sibling"] option Add ignore: ["next-sibling"] to selector-max-type Dec 1, 2018
jeddy3 and others added 2 commits December 1, 2018 19:06
Co-Authored-By: iliyaZelenko <iliyazelenkog@gmail.com>
@iliyaZelenko
Copy link
Member Author

This is my first time when I've done so much in someone else's repository. It's good that everything went well, I think in the future I will still do something for you.

Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes. It's looking good!

I've made three very minor doc tweak suggestions:

  • adding backticks around the heading
  • removing two empty lines

After that, I think it'll look good to me.

It's good that everything went well, I think in the future I will still do something for you.

Thanks for your contribution! It's appreciated :)

lib/rules/selector-max-type/README.md Outdated Show resolved Hide resolved
lib/rules/selector-max-type/README.md Outdated Show resolved Hide resolved
lib/rules/selector-max-type/README.md Show resolved Hide resolved
Co-Authored-By: iliyaZelenko <iliyazelenkog@gmail.com>
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@iliyaZelenko iliyaZelenko removed the request for review from alexander-akait December 14, 2018 23:16
@jeddy3
Copy link
Member

jeddy3 commented Dec 27, 2018

Does anyone have the time to provide a second review on this?

@jeddy3
Copy link
Member

jeddy3 commented Jan 2, 2019

@iliyaZelenko Sorry to trouble you once last time, but would you be able to resolve the conflicts so we can merge this?

@iliyaZelenko
Copy link
Member Author

iliyaZelenko commented Jan 2, 2019

No problem, it seems nothing complicated.

The tests did not pass, I will try to solve it in the near future.

@jeddy3
Copy link
Member

jeddy3 commented Jan 2, 2019

The tests did not pass, I will try to solve it in the near future.

I think we're simply missing the "next-sibling" option in the validator. It looks like it got removed when resolving the conflicts. Adding it back in should see the tests passing again. See:

ignore: ["descendant", "child", "compounded"],

@iliyaZelenko
Copy link
Member Author

@jeddy3 You are right, thank you, did not notice.

Everything is working.

@iliyaZelenko iliyaZelenko merged commit f895d16 into stylelint:master Jan 3, 2019
@jeddy3
Copy link
Member

jeddy3 commented Jan 3, 2019

Changelog entry added:

  • Added: ignore: ["next-sibling"] to selector-max-type (#3832).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants