Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't parse ignored files #3801

Merged
merged 2 commits into from Nov 13, 2018
Merged

Don't parse ignored files #3801

merged 2 commits into from Nov 13, 2018

Conversation

ccqgithub
Copy link
Contributor

… in these files.

Which issue, if any, is this issue related to?

A replacement for #3778.

now, below codes will throw a parse error even the .stylelintignore has pattern /**

const stylelint = require('stylelint');

stylelint.lint({
code: 'var a = {',
codeFilename: 'test.js',
}).then(data => console.log(data));

because lintsource throw parse error even the file is ignored.

this PR ignore files before lint, so avoid that errors.

Is there anything in the PR that needs further explanation?

e.g. "No, it's self explanatory."

@CAYdenberg
Copy link
Contributor

This looks ... good. Don't know why we weren't already doing this 👍

@jeddy3
Copy link
Member

jeddy3 commented Nov 12, 2018

@CAYdenberg Thanks for the review. I assume this is a patch and the following changelog entry will suffice?:

  • Fixed: ignored files are no longer parsed (#3801).

@jeddy3 jeddy3 changed the title just to ignore the ignored files before lint, to avoid parse errors Don't parse ignored files Nov 12, 2018
@CAYdenberg
Copy link
Contributor

CAYdenberg commented Nov 12, 2018 via email

@jeddy3 jeddy3 merged commit e8a91b9 into stylelint:master Nov 13, 2018
@ccqgithub
Copy link
Contributor Author

@jeddy3 When can publish a version that include this? The issue throw errors when i use stylelint with vscode 😸

@jeddy3
Copy link
Member

jeddy3 commented Nov 27, 2018

We can do a release today #3826.

@ccqgithub
Copy link
Contributor Author

Oh, very thanks...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants