Allow ordinary regular expressions anywhere a regex string is accepted in rule config #3799

CAYdenberg · 2018-11-09T22:29:57Z

Which issue, if any, is this issue related to?

Is there anything in the PR that needs further explanation?

My goal is to do one of these per (working) day until it's done ... I can submit them as separate PRs or just keep a running branch.

jeddy3

My goal is to do one of these per (working) day until it's done

Nice!

I can submit them as separate PRs or just keep a running branch.

Let's keep it running. We can always merge if you run out of steam :)

…ion in media-feature-name-value-whitelist

…oreMediaFeatureNames

… secondary options

…oreFunctions

… and ignoreKeywords

…property-unit-blacklist

…in selector-type-no-unknown

…to be RegExp

…cate-properties to be RegExp

…ore to be RegExp

…ate-names to be RegExp

…be RegExp

… be RegExp

…RegExp

…dant-longhand-properties to be RegExp

CAYdenberg · 2018-12-18T21:37:56Z

This is ready for a review if anyone can manage it.

Mostly, this is pretty formulaic, so if you look at one commit you've seen them all. The only exception is:
20ad772

where I had to change the util validateObjectWithStringArrayProps.

CAYdenberg · 2018-12-20T20:07:11Z

Should probably tag this @stylelint/core

Please review.

jeddy3

@CAYdenberg Thank you so much! I'm sure this PR was laborious, but it's fantastic to see it done!

LGTM.

jeddy3 · 2018-12-27T10:15:35Z

lib/rules/comment-word-blacklist/README.md

@@ -12,7 +12,7 @@ This rule ignores comments within selector and value lists.

 ## Options

-`array|string`: `["array", "of", "words", "or", "/regex/"]|"word"|"/regex/"`
+`array|string|regexp`: `["array", "of", "words", /or/, "/regex/"]|"word"|"/regex/"`


👍 - a nice way communicate this

jeddy3 · 2018-12-27T10:21:42Z

lib/rules/function-url-scheme-blacklist/__tests__/index.js

+      column: 21
+    },
+    {
+      code: "a { background: url(HTTPS://example.com/file.jpg); }",


Just a note that the regex should be case-sensitive unless it carries the i flag. We should pick this up in a separate issue, though.

alexander-akait

Good work!

CAYdenberg · 2018-12-27T21:20:57Z

Thanks everyone! ❤️

I still can't edit the CHANGELOG directly, so if someone could do that for me, it'd be swell.

jeddy3 · 2019-01-02T18:38:26Z

I still can't edit the CHANGELOG directly, so if someone could do that for me, it'd be swell.

Strange... done:

Added: support for ordinary regular expressions anywhere a regex string is accepted in rule config (#3799).

@CAYdenberg Thanks again for all the work you put into this PR!

I was on hols and offline for a few days, so I'm just catching up on all the PRs now.

Allow RegExp primary option for 'comment-word-blacklist'

5f6fb19

CAYdenberg changed the title ~~Allow RegExp primary option for 'comment-word-blacklist'~~ Allow ordinary regular expressions anywhere a regex string is accepted in rule config Nov 9, 2018

jeddy3 reviewed Nov 9, 2018

View reviewed changes

CAYdenberg changed the title ~~Allow ordinary regular expressions anywhere a regex string is accepted in rule config~~ WIP: Allow ordinary regular expressions anywhere a regex string is accepted in rule config Nov 9, 2018

CAYdenberg added 5 commits November 13, 2018 11:43

Allow RegExp primary option for function-*list

4b11ce2

Allow RegExp primary option for function-url-scheme-*list

47f7536

Allow RegExp for ignoreFunctions secondary option in function-name-case

d2be74e

Allow RegExp primary option in media-feature-name-*list

7dc5fb8

Allow tests and documentation showing that RegExp work as primary opt…

b3d506c

…ion in media-feature-name-value-whitelist

jeddy3 mentioned this pull request Nov 27, 2018

Release 9.9.0 #3826

Closed

4 tasks

CAYdenberg added 20 commits November 27, 2018 14:22

Allow RegExp primary option in property-*list

18fdfe0

Allow RegExp primary option in selector-pseudo-class-*list

2742e62

Allow RegExp in unit-*list secondary options ignoreProperties and ign…

ed56990

…oreMediaFeatureNames

Add validateObjectWithArrayProps as a flexible utility for evaluating…

20ad772

… secondary options

Allow RegExp in unit-no-unknown secondary options ignoreUnits and ign…

f27466c

…oreFunctions

Allow RegExp in value-keywork-case secondary options ignoreProperties…

69424dd

… and ignoreKeywords

Add tests and documentation for RegExp as value names in declaration-…

054126b

…property-unit-blacklist

Allow RegExp secondary option ignoreAtRules in at-rule-no-unknown

8f25fd4

Allow ignoreNamespace and ignoreTypes secondary options to be RegExp …

72bc6e2

…in selector-type-no-unknown

Allow ignoreUnits secondary option to be RegExp in number-max-precision

17c6e41

Allow ignoreProperties secondary option in property-no-vendor-prefix …

9dbc324

…to be RegExp

Allow ignoreProperties secondary option in declaration-block-no-dupli…

320c9e2

…cate-properties to be RegExp

Allow ignoreAtRules secondary option in block-opening-brace-space-bef…

a5b7c85

…ore to be RegExp

Allow ignorePattern secondary option in max-line-length to be RegExp

e4bdcac

Allow ignoreProperties secondary option in color-named to be RegExp

30dd2be

Allow ignoreFontFamilyNames secondary option in font-family-no-duplic…

46a98cd

…ate-names to be RegExp

Allow ignoreAttributes secondary option in selector-max-attribute to …

c2ba55c

…be RegExp

Allow ignoreSelectors secondary option in selector-max-specificity to…

fe93300

… be RegExp

Allow ignoreProperties secondary option in property-no-unknown to be …

4a28b13

…RegExp

Allow ignoreTypes secondary option in selector-max-type to be RegExp

dffebf1

CAYdenberg added 2 commits December 18, 2018 14:29

Allow ignoreAtRules secondary option in max-nesting-depth to be RegExp

ce796f7

Allow ignoreShorthands secondary option in declaration-block-no-redun…

c475f92

…dant-longhand-properties to be RegExp

CAYdenberg changed the title ~~WIP: Allow ordinary regular expressions anywhere a regex string is accepted in rule config~~ Allow ordinary regular expressions anywhere a regex string is accepted in rule config Dec 18, 2018

jeddy3 approved these changes Dec 27, 2018

View reviewed changes

jeddy3 mentioned this pull request Dec 27, 2018

Add ignoreFunctions: [] to font-weight-notation #3864

Closed

ntwb approved these changes Dec 27, 2018

View reviewed changes

alexander-akait approved these changes Dec 27, 2018

View reviewed changes

CAYdenberg merged commit 348c139 into master Dec 27, 2018

jeddy3 deleted the issue-3008 branch January 2, 2019 18:35

snyk-bot mentioned this pull request Sep 23, 2019

[Snyk] Upgrade stylelint from 9.6.0 to 9.10.1 maxiplux/blueprint#3

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow ordinary regular expressions anywhere a regex string is accepted in rule config #3799

Allow ordinary regular expressions anywhere a regex string is accepted in rule config #3799

CAYdenberg commented Nov 9, 2018 •

edited by jeddy3

jeddy3 left a comment

CAYdenberg commented Dec 18, 2018

CAYdenberg commented Dec 20, 2018

jeddy3 left a comment

jeddy3 Dec 27, 2018 •

edited

jeddy3 Dec 27, 2018

alexander-akait left a comment

CAYdenberg commented Dec 27, 2018

jeddy3 commented Jan 2, 2019 •

edited

Allow ordinary regular expressions anywhere a regex string is accepted in rule config #3799

Allow ordinary regular expressions anywhere a regex string is accepted in rule config #3799

Conversation

CAYdenberg commented Nov 9, 2018 • edited by jeddy3

jeddy3 left a comment

Choose a reason for hiding this comment

CAYdenberg commented Dec 18, 2018

CAYdenberg commented Dec 20, 2018

jeddy3 left a comment

Choose a reason for hiding this comment

jeddy3 Dec 27, 2018 • edited

Choose a reason for hiding this comment

jeddy3 Dec 27, 2018

Choose a reason for hiding this comment

alexander-akait left a comment

Choose a reason for hiding this comment

CAYdenberg commented Dec 27, 2018

jeddy3 commented Jan 2, 2019 • edited

CAYdenberg commented Nov 9, 2018 •

edited by jeddy3

jeddy3 Dec 27, 2018 •

edited

jeddy3 commented Jan 2, 2019 •

edited