Fix false positives for Less variables and mixins in at-rule-* (#3749) #3759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeddy3
approved these changes
Oct 30, 2018
| @@ -260,7 +260,7 @@ testRule(rule, { | |||
| }, | |||
| { | |||
| code: "@import 'test'; @include mixin(1) { @content; };", | |||
| fixed: "@import 'test';\n\n @include mixin(1) {\n\n @content; };", | |||
There was a problem hiding this comment.
This changed is due to this bit in the isStandardSyntaxAtRule util. I'd consider the existing behaviour a bug and the changes in this PR fix it, even though it's unrelated to Less Syntax.
alexander-akait
approved these changes
Oct 30, 2018
|
|
@jeddy3: will you cut a new patch release for this soon too? |
|
Yes, already on it #3763 |
|
It seems the same problem is still happening for the tule |
This was referenced Oct 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3749
No, it's self explanatory.