Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add autofix to selector-attribute-brackets-space-inside #3605

Merged
merged 1 commit into from Sep 6, 2018
Merged

Add autofix to selector-attribute-brackets-space-inside #3605

merged 1 commit into from Sep 6, 2018

Conversation

ota-meshi
Copy link
Member

Which issue, if any, is this issue related to?

closes #3583

Is there anything in the PR that needs further explanation?

ex.

  • option: always

    code:

    [target="_blank"] { }

    fixed:

    [ target="_blank" ] { }

  • option: never

    code:

    [ target="_blank" ] { }

    fixed:

    [target="_blank"] { }

ota-meshi
ota-meshi commented Aug 25, 2018
View reviewed changes
lib/rules/selector-attribute-brackets-space-inside/__tests__/index.js
},
{
code: "[foo=bar i/**/] { }",
fixed: "[ foo=bar i ] { }", // bug? postcss-selector-parser
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened the PR.
postcss/postcss-selector-parser#151

jeddy3
jeddy3 approved these changes Sep 6, 2018
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeddy3 jeddy3 merged commit b9c1d96 into master Sep 6, 2018
@jeddy3 jeddy3 deleted the add-autofix/selector-attribute-brackets-space-inside branch September 6, 2018 13:17
@jeddy3
Copy link
Member

jeddy3 commented Sep 6, 2018

  • Added: selector-attribute-brackets-space-inside autofix (#3605).

This was referenced Sep 27, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeddy3 jeddy3 jeddy3 approved these changes

@ntwb ntwb ntwb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add autofix to selector-attribute-brackets-space-inside
3 participants
@ota-meshi @jeddy3 @ntwb