Fix incorrect font-family-no-missing-generic-family-keyword configuration #3038 #3039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CAYdenberg
suggested changes
Nov 30, 2017
| }); | ||
|
|
||
| expect(result.warn.mock.calls[0]).toHaveLength(2); | ||
| expect(result.warn.mock.calls[0][0]).toEqual( |
There was a problem hiding this comment.
Can you use toHaveBeenCalledTimes and toHaveBeenCalledWith? Just easier to read for someone unfamiliar with Jest.
There was a problem hiding this comment.
I used same matchers as other tests in this file for consistency.
There was a problem hiding this comment.
Weird, I thought I changed all of those when we removed Sinon. Oh well, point taken.
CAYdenberg
approved these changes
Dec 1, 2017
alexander-akait
approved these changes
Dec 1, 2017
|
@CAYdenberg when you merge PR, please, delete branch and update changelog. |
This was referenced Dec 15, 2017
This was referenced Mar 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3038
I've added a test to
validateOptions, but it doesn't catch an error. It will only show an error if test with configuration like in #3038 run.I think we can add a new type of test in
jest-setup.js. Take firstaccepttest, addseveritysecondary option, and run test. There is a little warning: most test cases useconfig: ["value"], while very few useconfig: [["value"]](which is probably should be fixed). I can't think straight anymore today, so I'm not including this change forjest-setup.jsin this PR.