Fixed: ignore variables with signs in value-keyword-case.
#2558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntwb
reviewed
May 8, 2017
lib/utils/isStandardSyntaxValue.js
Outdated
| @@ -6,18 +6,26 @@ const hasInterpolation = require("../utils/hasInterpolation") | |||
| * Check whether a value is standard | |||
| */ | |||
| module.exports = function (value/*: string*/)/*: boolean*/ { | |||
| let normalizedValue = value | |||
|
|
|||
| // Ignore signs before variable (example `-$variable`) | |||
There was a problem hiding this comment.
Maybe Ignore operators before variables (example -$variable) instead of signs?
lib/utils/isStandardSyntaxValue.js
Outdated
| let normalizedValue = value | ||
|
|
||
| // Ignore signs before variable (example `-$variable`) | ||
| // Sings `*` and `/` should be removed after resolve this issue in `postcss-value-parser` |
There was a problem hiding this comment.
Spelling Signs, not Sings, or Operators based on comment above
alexander-akait
force-pushed
the
issue-2404
branch
from
72257f2
to
f460477
Compare
|
/cc @ntwb |
lib/utils/isStandardSyntaxValue.js
Outdated
| let normalizedValue = value | ||
|
|
||
| // Ignore operators before variables (example -$variable) | ||
| if (value[0] === "-" || value[0] === "+" || value[0] === "*" || value[0] === "/") { |
There was a problem hiding this comment.
A regular expression makes more sense here, I think. Something like /^[-+\*\/]/.
There was a problem hiding this comment.
You don't even need to escape, if I'm not mistaken: /^[-+*/]/.
|
@evilebottnawi Am I right in thinking this PR supersedes #2438? |
|
@jeddy3 yep, we can close this issue |
hudochenkov
approved these changes
May 25, 2017
|
LGTM after David's request is addressed: https://github.com/stylelint/stylelint/pull/2558/files#r116360039 |
alexander-akait
force-pushed
the
issue-2404
branch
from
f460477
to
68bbd46
Compare
|
Changelog:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2404
No, it's self explanatory.