Fix max-line-length column incorrect column #2287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeddy3
changed the title
davidtheclark
force-pushed
the
max-line-length-bad-column
branch
from
5942c48
to
646f50c
Compare
|
I added a commit that fixes this test, so closes #2286. It also fixes the incorrect positions in system test 005 that corresponded to this problem. |
jeddy3
approved these changes
Jan 29, 2017
|
Added to Changelog:
|
sergesemashko
pushed a commit
to sergesemashko/stylelint
that referenced
this pull request
Mar 3, 2017
* Add a failing test for issue stylelint#2286 * Fix max-line-length column number for lines with urls Closes stylelint#2286
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2286
The test will fail with:
FAIL lib/rules/max-line-length/__tests__/index.js ● max-line-length › reject › no description expect(received).toBe(expected) Expected value to be (using ===): 48 Received: 30 at stylelint.then.output (jest-setup.js:55:50)