Deprecate additional rules #2285
Conversation
| @@ -1,5 +1,7 @@ | |||
| # time-no-imperceptible | |||
|
|
|||
| ***Deprecated: this rule is outside the scope of stylelint's functionality. See [the release planning docs](https://stylelint.io/user-guide/release-planning/) for details.*** | |||
There was a problem hiding this comment.
This time-no-imperceptible rule is being replaced with a more appropriately and more versatile rule named time-min-milliseconds. See #2249
There was a problem hiding this comment.
But technically new rule isn't here yet. What if it wouldn't be here when these changes will be released?
There was a problem hiding this comment.
We won't be releasing the deprecations branch until the alternative within stylelint are done. So, updating this message to reference time-min-milliseconds SGTM. Otherwise we'll likely forget to do it when time-min-milliseconds is added.
There was a problem hiding this comment.
Agreed. time-min-milliseconds is on its way #2289
There was a problem hiding this comment.
Awesome. Let's update this message to:
***Deprecated: use the time-min-milliseconds rule with 100 as its primary option. ***
|
@ntwb I think that's a good idea. Just looking at the latest changelog, maybe I should add ' If you use this rule, please consider creating a plugin for the community.' to some of the other rules. |
|
Epic job with this @m-allanson btw! |
#2123
Deprecates the following rules: