Add ignoreSelectors: [] to selector-no-vendor-prefix (#3748)

* Add ignoreProperties: [] to selector-no-vendor-prefix * Use optionsMatches util * Fix to pseudo element * Replace ignoreProperties with ignoreSelectors Co-Authored-By: Bilie <bilianavaleva@gmail.com> * Replace ignoreProperties with ignoreSelectors Co-Authored-By: Bilie <bilianavaleva@gmail.com> * Replace ignoreProperties with ignoreSelectors Co-Authored-By: Bilie <bilianavaleva@gmail.com> * Replace ignoreProperties with ignoreSelectors Co-Authored-By: Bilie <bilianavaleva@gmail.com>
stylelint · Nov 27, 2018 · ac09f8d · ac09f8d
1 parent 25c3d0a
commit ac09f8d
Show file tree

Hide file tree

Showing 3 changed files with 67 additions and 2 deletions.
diff --git a/lib/rules/selector-no-vendor-prefix/README.md b/lib/rules/selector-no-vendor-prefix/README.md
@@ -33,3 +33,27 @@ input::placeholder {}
 ```css
 :full-screen a {}
 ```
+
+## Optional secondary options
+
+### `ignoreSelectors: ["/regex/", "non-regex"]`
+
+Ignore vendor prefixes for selectors.
+
+Given:
+
+```js
+["::-webkit-input-placeholder", "/-moz-.*/"]
+```
+
+The following patterns are not considered violations:
+
+```css
+input::-webkit-input-placeholder {
+  color: pink;
+}
+
+input::-moz-placeholder {
+  color: pink;
+}
+```
diff --git a/lib/rules/selector-no-vendor-prefix/__tests__/index.js b/lib/rules/selector-no-vendor-prefix/__tests__/index.js
@@ -87,3 +87,27 @@ testRule(rule, {
     }
   ]
 });
+
+testRule(rule, {
+  ruleName,
+  config: [
+    true,
+    { ignoreSelectors: ["::-webkit-input-placeholder", "/-moz-.*/"] }
+  ],
+
+  accept: [
+    {
+      code: "input::-webkit-input-placeholder { color: pink; }"
+    },
+    {
+      code: "input::-moz-placeholder { color: pink; }"
+    }
+  ],
+
+  reject: [
+    {
+      code: "input::-ms-input-placeholder { color: pink; }",
+      message: messages.rejected("::-ms-input-placeholder")
+    }
+  ]
+});
diff --git a/lib/rules/selector-no-vendor-prefix/index.js b/lib/rules/selector-no-vendor-prefix/index.js
@@ -1,8 +1,10 @@
 "use strict";
 
+const _ = require("lodash");
 const isAutoprefixable = require("../../utils/isAutoprefixable");
 const isStandardSyntaxRule = require("../../utils/isStandardSyntaxRule");
 const isStandardSyntaxSelector = require("../../utils/isStandardSyntaxSelector");
+const optionsMatches = require("../../utils/optionsMatches");
 const parseSelector = require("../../utils/parseSelector");
 const report = require("../../utils/report");
 const ruleMessages = require("../../utils/ruleMessages");
@@ -14,9 +16,20 @@ const messages = ruleMessages(ruleName, {
   rejected: selector => `Unexpected vendor-prefix "${selector}"`
 });
 
-const rule = function(actual) {
+const rule = function(actual, options) {
   return (root, result) => {
-    const validOptions = validateOptions(result, ruleName, { actual });
+    const validOptions = validateOptions(
+      result,
+      ruleName,
+      { actual },
+      {
+        actual: options,
+        possible: {
+          ignoreSelectors: [_.isString]
+        },
+        optional: true
+      }
+    );
 
     if (!validOptions) {
       return;
@@ -36,6 +49,10 @@ const rule = function(actual) {
       parseSelector(selector, result, rule, selectorTree => {
         selectorTree.walkPseudos(pseudoNode => {
           if (isAutoprefixable.selector(pseudoNode.value)) {
+            if (optionsMatches(options, "ignoreSelectors", pseudoNode.value)) {
+              return;
+            }
+
             report({
               result,
               ruleName,