Fix false positives for flush comments containing a comma in selector…

…-max-universal (#3817)
stylelint · Jan 10, 2019 · 584876d · 584876d
1 parent 754bf92
commit 584876d
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/lib/rules/selector-max-universal/__tests__/index.js b/lib/rules/selector-max-universal/__tests__/index.js
@@ -18,6 +18,9 @@ testRule(rule, {
     {
       code: "foo .bar {}"
     },
+    {
+      code: ".foo,/* .class, */.bar {}"
+    },
     {
       code: "#foo {}"
     },

diff --git a/lib/rules/selector-max-universal/index.js b/lib/rules/selector-max-universal/index.js
@@ -6,6 +6,7 @@ const parseSelector = require("../../utils/parseSelector");
 const report = require("../../utils/report");
 const resolvedNestedSelector = require("postcss-resolve-nested-selector");
 const ruleMessages = require("../../utils/ruleMessages");
+const selectorParser = require("postcss-selector-parser");
 const validateOptions = require("../../utils/validateOptions");
 
 const ruleName = "selector-max-universal";
@@ -75,7 +76,21 @@ function rule(max) {
         return;
       }
 
-      ruleNode.selectors.forEach(selector => {
+      const selectors = [];
+
+      selectorParser()
+        .astSync(ruleNode.selector)
+        .walk(node => {
+          if (node.type === "selector") {
+            selectors.push(
+              String(node)
+                .replace(/^(\s*)/m, "")
+                .replace(/(\s*)$/m, "")
+            );
+          }
+        });
+
+      selectors.forEach(selector => {
         resolvedNestedSelector(selector, ruleNode).forEach(resolvedSelector => {
           parseSelector(resolvedSelector, result, ruleNode, container =>
             checkSelector(container, ruleNode)