perf: skip buffer decoding on overage chunk

closes #54
stream-utils · Sep 8, 2017 · afcb732 · afcb732
1 parent b545644
commit afcb732
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/HISTORY.md b/HISTORY.md
@@ -4,6 +4,7 @@ unreleased
   * deps: bytes@3.0.0
   * deps: http-errors@1.6.2
     - deps: depd@1.1.1
+  * perf: skip buffer decoding on overage chunk
 
 2.3.0 / 2017-08-04
 ==================

diff --git a/index.js b/index.js
@@ -242,18 +242,16 @@ function readStream (stream, encoding, length, limit, callback) {
 
     received += chunk.length
 
-    if (decoder) {
-      buffer += decoder.write(chunk)
-    } else {
-      buffer.push(chunk)
-    }
-
     if (limit !== null && received > limit) {
       done(createError(413, 'request entity too large', {
         limit: limit,
         received: received,
         type: 'entity.too.large'
       }))
+    } else if (decoder) {
+      buffer += decoder.write(chunk)
+    } else {
+      buffer.push(chunk)
     }
   }