Storyshots: Fix support for jsx/tsx config files #9834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidgoli
commented
Feb 12, 2020
| .flatMap(filename => supportedExtensions.map(ext => `${filename}.${ext}`)) | ||
| .map(filename => path.join(configDir, filename)); | ||
|
|
||
| return allFilenames.find(isFile) || false; | ||
| }; | ||
|
|
||
| const getMainFile = (configDir: string): string | false => { |
There was a problem hiding this comment.
question: should the same file extension support be implemented for main.js as well?
davidgoli
force-pushed
the
support-jsx-preview-files
branch
from
999412e
to
d1e5349
Compare
davidgoli
force-pushed
the
support-jsx-preview-files
branch
from
d1e5349
to
2fe47b6
Compare
shilman
changed the title
shilman
added
the
patch:yes
ndelangen
approved these changes
Feb 14, 2020
|
Awesome, looks great to me! |
|
Great job @davidgoli. Clean!!! ✨ |
shilman
added
the
patch:done
shilman
pushed a commit
that referenced
this pull request
Feb 25, 2020
Storyshots: Fix support for jsx/tsx config files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #9771
What I did
Implemented support for *.jsx and *.tsx preview files.
How to test