Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Move addon dependencies to devDependencies #8206

Merged
merged 1 commit into from Sep 26, 2019

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen added bug ui patch:yes Bugfix & documentation PR that need to be picked to main branch labels Sep 26, 2019
@ndelangen ndelangen added this to the 5.2.x milestone Sep 26, 2019
@ndelangen ndelangen self-assigned this Sep 26, 2019
@vercel
Copy link

vercel bot commented Sep 26, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-fix-lib-ui-depends-on-some-addons.storybook.now.sh

@stof
Copy link
Contributor

stof commented Sep 26, 2019

should this be done in master rather than next, to have it in a 5.2 release too ?

@ndelangen
Copy link
Member Author

That's what the patch label does, this will be picked unto master and released as a 5.2 patch

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants