Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow JSX.Element story #8159

Merged
merged 1 commit into from Sep 24, 2019
Merged

fix: Allow JSX.Element story #8159

merged 1 commit into from Sep 24, 2019

Conversation

9renpoto
Copy link
Contributor

@9renpoto 9renpoto commented Sep 23, 2019

What I did

How to test

  • Added tsconfig.json
{
  "compilerOptions": {
    "jsx": "preserve",
    "module": "esnext",
    "moduleResolution": "node",
    "jsxFactory": "h",
    "strict": true,
    "target": "esnext"
  }
}
  • And use styled-components and PreactX

If your answer is yes to any of these, please make sure to include it in your PR.

@vercel
Copy link

vercel bot commented Sep 23, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-fork-9renpoto-fix-preact-story-fn-return-type.storybook.now.sh

@ndelangen ndelangen added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Sep 24, 2019
@ndelangen ndelangen merged commit f947b05 into storybookjs:next Sep 24, 2019
@9renpoto
Copy link
Contributor Author

🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch preact typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants