Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing type def to addon-knobs fixes #8105 #8118

Merged
merged 1 commit into from Sep 21, 2019
Merged

add missing type def to addon-knobs fixes #8105 #8118

merged 1 commit into from Sep 21, 2019

Conversation

hipstersmoothie
Copy link
Contributor

@hipstersmoothie hipstersmoothie commented Sep 18, 2019 •
edited

Issue: fixes #8105

What I did

Move types for react-color to deps since those types end up in the build output and are required

How to test

  • Is this testable with Jest or Chromatic screenshots? no
  • Does this need a new example in the kitchen sink apps? no
  • Does this need an update to the documentation? no

If your answer is yes to any of these, please make sure to include it in your PR.

@hipstersmoothie hipstersmoothie added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Sep 18, 2019
@vercel
Copy link

vercel bot commented Sep 18, 2019 •
edited

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-types.storybook.now.sh

@hipstersmoothie hipstersmoothie changed the title Types add missing type def to addon-knobs fixes #8105 Sep 18, 2019
@github-actions
Copy link
Contributor

Fails
🚫

PR is not labeled with one of: ["cleanup","doc-dependencies:update","BREAKING CHANGE","feature request","bug","documentation","maintenance","dependencies:update","dependencies","other"]

Generated by 🚫 dangerJS against d7b89f4

@shilman
Copy link
Member

shilman commented Sep 19, 2019

@kroeder @gaetanmaisse @emilio-martinez can one of you take a look at this?

emilio-martinez
emilio-martinez approved these changes Sep 20, 2019
View reviewed changes
Copy link
Contributor

@emilio-martinez emilio-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The DefinitelyTyped repo seems to follow a similar practice when establishing dependencies between types that depend on other package's types.

@shilman shilman merged commit 5ab1e07 into next Sep 21, 2019
@shilman shilman deleted the types branch September 21, 2019 07:03
@shilman shilman mentioned this pull request Sep 24, 2019
Closed
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Oct 7, 2019
shilman added a commit that referenced this pull request Oct 7, 2019
@shilman
add missing type def to addon-knobs fixes #8105 (#8118)
9bf9150 
add missing type def to addon-knobs fixes #8105
This was referenced Oct 17, 2019
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilio-martinez emilio-martinez emilio-martinez approved these changes

@alexandrebodin alexandrebodin Awaiting requested review from alexandrebodin

@alterx alterx Awaiting requested review from alterx

@leonrodenburg leonrodenburg Awaiting requested review from leonrodenburg

@theinterned theinterned Awaiting requested review from theinterned

Assignees
No one assigned
Labels
bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SB 5.2 Typescript build fail - (Addon-knobs)
3 participants
@hipstersmoothie @shilman @emilio-martinez