fix: add missing core-js dependency #7016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should resolve the issue some people are seeing in storybookjs#6204
ForbesLindesay
requested review from
danielduan,
Gongreg,
rmevans9 and
tmeasday
as code owners
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-fork-forbeslindesay-patch-2.storybook.now.sh |
shilman
added
react-native
dependencies
patch:yes
shilman
pushed a commit
that referenced
this pull request
Jun 13, 2019
fix: add missing core-js dependency
shilman
added
the
patch:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve the issue some people are seeing in #6204
What I did
Added an explicit dependency on core-js. This was mostly working before because the dependency flattening means most people have a copy of core-js in their node_modules folder, but after version 3 was released, some people had version 2 and others had version 3. This explicitly adds the dependency on version 3.