chore: set react version to 16.8.3 to match react native #7008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
requested review from
CodeByAlex,
dangreenisrael,
danielduan,
igor-dv,
jbovenschen,
ndelangen,
renaudtertrais,
theinterned,
thomasbertet,
tmeasday,
usulpro and
z4o4z
as code owners
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-fork-simenb-react-16-8-3.storybook.now.sh |
ndelangen
approved these changes
Jun 7, 2019
ndelangen
approved these changes
Jun 7, 2019
ndelangen
added
the
patch:yes
shilman
pushed a commit
that referenced
this pull request
Jun 13, 2019
chore: set react version to 16.8.3 to match react native
shilman
added
the
patch:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: N/A
What I did
Set the version range of the react dependencies to not be higher than the version of React that React Native works with (https://github.com/facebook/react-native/blob/v0.59.9/package.json#L158). This allows us to get the correct peer dependency without warnings or worrying about dependency hoisting and small inconsistencies.
How to test
If your answer is yes to any of these, please make sure to include it in your PR.