Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Include @storybook/addon-svelte-csf when initializing new projects #27070

Merged
merged 6 commits into from May 14, 2024

Conversation

benmccann
Copy link
Contributor

@benmccann benmccann commented May 8, 2024

Progress towards #21043

What I did

  • Update extensions used in Svelte projects
  • Add @storybook/addon-svelte-csf

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

Tested the CLI tool against a newly initialized Svelte+Vite project and SvelteKit project

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This pull request has been released as version 0.0.0-pr-27070-sha-e0acab3b. Try it out in a new sandbox by running npx storybook@0.0.0-pr-27070-sha-e0acab3b sandbox or in an existing project with npx storybook@0.0.0-pr-27070-sha-e0acab3b upgrade.

More information
Published version 0.0.0-pr-27070-sha-e0acab3b
Triggered by @JReinhold
Repository benmccann/storybook
Branch csf-init
Commit e0acab3b
Datetime Wed May 8 21:00:14 UTC 2024 (1715202014)
Workflow run 9008463308

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=27070

Copy link

nx-cloud bot commented May 8, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6483a4f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@benmccann
Copy link
Contributor Author

@manuel3108 @tburny FYI. This was inspired by svelte-compose/svelte-compose#10 and should make it a bit easier to get going with @storybook/addon-svelte-csf. There's more we could do, but it's a good start

@JReinhold JReinhold added ci:daily Run the CI jobs that normally run in the daily job. feature request labels May 8, 2024
@JReinhold JReinhold changed the title CLI: init Svelte projects with @storybook/addon-svelte-csf CLI: init Svelte projects with @storybook/addon-svelte-csf May 8, 2024
@JReinhold JReinhold self-assigned this May 13, 2024
@JReinhold JReinhold changed the title CLI: init Svelte projects with @storybook/addon-svelte-csf CLI: Include @storybook/addon-svelte-csf when initializing new projects May 14, 2024
Copy link
Contributor

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JReinhold JReinhold merged commit 4b21a08 into storybookjs:next May 14, 2024
101 of 102 checks passed
@github-actions github-actions bot mentioned this pull request May 14, 2024
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:daily Run the CI jobs that normally run in the daily job. cli feature request svelte sveltekit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants