Core: Replace express with connect

[43081j]

Migrates away from express, instead using connect and the underlying node server directly.

Both express and connect support the same middleware structure, which means most middleware packages work for both and have remained the same in this change.

A few notes:

• Express' router has been replaced by basic connect mount points (though the two are not equivalent exactly)
• Express static has been replaced by sirv

This trims a large sub-tree of dependencies from our packages which express was pulling in. We in fact use very little of the functionality express gives us, only really making use of the connect-style API anyway.

I've left a few TODOs around the code while this is a draft to help guide reviewers until it is done (if ever)

Express static

Replacing this with sirv means it isn't as simple as mounting real paths at aliased paths, since sirv takes a single directory as its source.

Due to this, we give it process.cwd() and mutate req.url to be the path relative to cwd.

Express router

We previously exposed router to managers and a few other middleware factories. These now consume an app (a connect Server).

A few main differences between the "full fat" router and basic mounts:

• No params, parsed query strings, etc
• Matches the prefix rather than the whole route
  • This means app('/foo', fn) would match /foo/bar too, and fn would receive {url: '/bar'} (relative to the mount point)

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

• stories
• unit tests
• integration tests
• end-to-end tests

Manual testing

Run the sandbox and observe that it all works as expected

Documentation

• Add or update documentation reflecting your changes
• If you are deprecating/removing a feature, make sure to update
  MIGRATION.MD

Checklist for Maintainers

• When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

• Make sure this PR contains one of the labels below:

  Available labels

  • bug: Internal changes that fixes incorrect behavior.
  • maintenance: User-facing maintenance tasks.
  • dependencies: Upgrading (sometimes downgrading) dependencies.
  • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
  • cleanup: Minor cleanup style change. Will not show up in release changelog.
  • documentation: Documentation only changes. Will not show up in release changelog.
  • feature request: Introducing a new feature.
  • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
  • other: Changes that don't fit in the above categories.

cc @ndelangen

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 66d27f8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 1 target

• nx run-many -t build -c production --parallel=3

---

Sent with 💌 from NxCloud.

[ndelangen]

Is there any way we can make this backwards compatible?

[43081j]

it may be difficult since router is basically the {get, post} shape etc

maybe we could have a wrapper around the connect server which does these 🤔

something like:

const router = {
  get(path, callback) {
    app(path, (req, res, next) => {
      // check the method is `GET` here and do nothing if it isn't
      callback(req, res, next);
    });
  },
  // ...
};

although keep in mind path would be treated as a prefix rather than a route pattern (i.e. /foo would capture /foo/bar, and there's no such thing as /foo/:someParam anymore, i.e. params).

[43081j]

@ndelangen got the tests passing for you FYI 👍