Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: introduce nissuer #26908

Closed
wants to merge 7 commits into from

Conversation

balazsorban44
Copy link
Contributor

@balazsorban44 balazsorban44 commented Apr 22, 2024

Opening based on: https://twitter.com/DrReinhold/status/1782358872738427056

See a test run here: balazsorban44#4

Showcases:

  • The issue was auto-labeled based on the user selection
  • Closed/locked, since it did not contain a reproduction from a valid host
  • A comment was added to explain the user the next steps
  • Adding the resolved and good first issue labels will auto-add a useful comment with next steps
  • Minimizing of +1 and same issue comments, with an explanation

For more info, check out https://github.com/balazsorban44/nissuer or reach me on Twitter

cc @JReinhold

@balazsorban44 balazsorban44 changed the base branch from main to next April 22, 2024 11:12
@balazsorban44 balazsorban44 marked this pull request as draft April 22, 2024 11:16
@balazsorban44 balazsorban44 marked this pull request as ready for review April 22, 2024 11:19
@vanessayuenn vanessayuenn self-requested a review April 22, 2024 16:15
@yannbf yannbf added build Internal-facing build tooling & test updates ci:normal labels Apr 29, 2024
@yannbf
Copy link
Member

yannbf commented Apr 29, 2024

Hey @balazsorban44 thanks a lot for your contribution! @vanessayuenn @JReinhold would you mind taking a look?

@balazsorban44
Copy link
Contributor Author

Let me know if anything is missing! (Feel free to ping on Twitter if I don't respond)

Copy link

nx-cloud bot commented May 15, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit bfdbaf7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link
Contributor

@vanessayuenn vanessayuenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some tweaks to your original PR. I decided to only incorporate the repro link + good first issue comment for now, as those don't deviate much with our current workflow. We will consider turning on the other features when we're ready to rework our triage workflow.

Thank you so much for this contribution! Looking forward to it making my life easier. ✨

@vanessayuenn vanessayuenn added ci:docs Run the CI jobs for documentation checks only. and removed ci:normal labels May 15, 2024
@vanessayuenn vanessayuenn mentioned this pull request May 15, 2024
8 tasks
@vanessayuenn
Copy link
Contributor

Merged via #27160 because the checks are not running properly on the fork here. Thank you again @balazsorban44!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:docs Run the CI jobs for documentation checks only.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants