Merge pull request #9873 from storybookjs/9827-ts-default-values

Props: Fix typescript unspecified default value
storybookjs · Feb 20, 2020 · 3aa12e9 · 3aa12e9
2 parents e04d5da + e5698fc
commit 3aa12e9
Show file tree

Hide file tree

Showing 9 changed files with 13 additions and 49 deletions.
diff --git a/addons/docs/src/frameworks/react/__testfixtures__/8143-ts-imported-types/properties.snapshot b/addons/docs/src/frameworks/react/__testfixtures__/8143-ts-imported-types/properties.snapshot
@@ -4,10 +4,7 @@ exports[`react component properties 8143-ts-imported-types 1`] = `
 Object {
   "rows": Array [
     Object {
-      "defaultValue": Object {
-        "detail": undefined,
-        "summary": "0",
-      },
+      "defaultValue": null,
       "description": "",
       "name": "bar",
       "required": true,

diff --git a/addons/docs/src/frameworks/react/__testfixtures__/9493-ts-display-name/properties.snapshot b/addons/docs/src/frameworks/react/__testfixtures__/9493-ts-display-name/properties.snapshot
@@ -17,10 +17,7 @@ Object {
       },
     },
     Object {
-      "defaultValue": Object {
-        "detail": undefined,
-        "summary": "1",
-      },
+      "defaultValue": null,
       "description": "A message alerting about Empire activities.",
       "name": "message",
       "required": true,

diff --git a/addons/docs/src/frameworks/react/__testfixtures__/9591-ts-import-types/properties.snapshot b/addons/docs/src/frameworks/react/__testfixtures__/9591-ts-import-types/properties.snapshot
@@ -4,10 +4,7 @@ exports[`react component properties 9591-ts-import-types 1`] = `
 Object {
   "rows": Array [
     Object {
-      "defaultValue": Object {
-        "detail": undefined,
-        "summary": "0",
-      },
+      "defaultValue": null,
       "description": "",
       "name": "other",
       "required": false,

diff --git a/addons/docs/src/frameworks/react/__testfixtures__/9592-ts-styled-props/properties.snapshot b/addons/docs/src/frameworks/react/__testfixtures__/9592-ts-styled-props/properties.snapshot
@@ -4,10 +4,7 @@ exports[`react component properties 9592-ts-styled-props 1`] = `
 Object {
   "rows": Array [
     Object {
-      "defaultValue": Object {
-        "detail": undefined,
-        "summary": "0",
-      },
+      "defaultValue": null,
       "description": "",
       "name": "title",
       "required": true,

diff --git a/...s/docs/src/frameworks/react/__testfixtures__/9721-ts-deprecated-jsdoc/properties.snapshot b/...s/docs/src/frameworks/react/__testfixtures__/9721-ts-deprecated-jsdoc/properties.snapshot
@@ -4,10 +4,7 @@ exports[`react component properties 9721-ts-deprecated-jsdoc 1`] = `
 Object {
   "rows": Array [
     Object {
-      "defaultValue": Object {
-        "detail": undefined,
-        "summary": "0",
-      },
+      "defaultValue": null,
       "description": "",
       "name": "width",
       "required": true,
@@ -17,10 +14,7 @@ Object {
       },
     },
     Object {
-      "defaultValue": Object {
-        "detail": undefined,
-        "summary": "1",
-      },
+      "defaultValue": null,
       "description": "The size (replaces width)",
       "name": "size",
       "required": true,

diff --git a/addons/docs/src/frameworks/react/__testfixtures__/9764-ts-extend-props/properties.snapshot b/addons/docs/src/frameworks/react/__testfixtures__/9764-ts-extend-props/properties.snapshot
@@ -4,10 +4,7 @@ exports[`react component properties 9764-ts-extend-props 1`] = `
 Object {
   "rows": Array [
     Object {
-      "defaultValue": Object {
-        "detail": undefined,
-        "summary": "0",
-      },
+      "defaultValue": null,
       "description": "The input content value",
       "name": "value",
       "required": false,
@@ -17,10 +14,7 @@ Object {
       },
     },
     Object {
-      "defaultValue": Object {
-        "detail": undefined,
-        "summary": "1",
-      },
+      "defaultValue": null,
       "description": "",
       "name": "defaultChecked",
       "required": false,
@@ -30,10 +24,7 @@ Object {
       },
     },
     Object {
-      "defaultValue": Object {
-        "detail": undefined,
-        "summary": "2",
-      },
+      "defaultValue": null,
       "description": "",
       "name": "checked",
       "required": false,

diff --git a/addons/docs/src/frameworks/react/__testfixtures__/9827-ts-default-values/properties.snapshot b/addons/docs/src/frameworks/react/__testfixtures__/9827-ts-default-values/properties.snapshot
@@ -17,10 +17,7 @@ Object {
       },
     },
     Object {
-      "defaultValue": Object {
-        "detail": undefined,
-        "summary": "1",
-      },
+      "defaultValue": null,
       "description": "",
       "name": "foo",
       "required": true,
@@ -30,10 +27,7 @@ Object {
       },
     },
     Object {
-      "defaultValue": Object {
-        "detail": undefined,
-        "summary": "2",
-      },
+      "defaultValue": null,
       "description": "",
       "name": "bar",
       "required": false,

diff --git a/addons/docs/src/frameworks/react/__testfixtures__/ts-function-component/properties.snapshot b/addons/docs/src/frameworks/react/__testfixtures__/ts-function-component/properties.snapshot
@@ -30,10 +30,7 @@ Object {
       },
     },
     Object {
-      "defaultValue": Object {
-        "detail": undefined,
-        "summary": "2",
-      },
+      "defaultValue": null,
       "description": "Simple click handler",
       "name": "onClick",
       "required": false,

diff --git a/addons/docs/src/frameworks/react/typeScript/handleProp.ts b/addons/docs/src/frameworks/react/typeScript/handleProp.ts
@@ -23,5 +23,5 @@ export function enhanceTypeScriptProp(extractedProp: ExtractedProp, rawDefaultPr
 }
 
 export function enhanceTypeScriptProps(extractedProps: ExtractedProp[]): PropDef[] {
-  return extractedProps.map(enhanceTypeScriptProp);
+  return extractedProps.map(prop => enhanceTypeScriptProp(prop));
 }