Fix bug with supporting multiple contextual modules of one type #1222
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes and adds tests for a problem with multiple clones (#1221). The fix is prevent only a single contextual loaded module from being created. Previously, a new contextual module would be defined only if the following check passed:
As name was always
steal-clone
, this would only allow one contextual module.I changed to to:
This will only allow one contextual module of that
name+parentName
combination to be loaded.Test are not passing for me locally ... I assume this is because I'm on node 5.Because I didn't have bower installed.