bundle assets in slim loader

[pYr0x]

blocked by: stealjs/steal-bundler#30

this PR integrates steal-serviceworker
and close #846 and close #825

the code i added can definitely refactored.

// run external steal-tool plugins after the build
				if(options){

					var p = Promise.resolve(builtResult);

					if(options.bundleAssets){
						var bundleAssets = require("steal-bundler");
						p = p.then(function(builtResult) {
							return bundleAssets(builtResult, options.bundleAssets);
						});
					}

					if(options.serviceWorker){
						var precache = require("steal-serviceworker");
						p = p.then(function (builtResult) {
							return precache(builtResult, options.serviceWorker);
						});
					}
				}

				p.then(function (builtResult) {
					resolve(builtResult);
				}).catch(function (error) {
					reject(error);
				});

but for now we can live with that.

maybe we can create some API for post-plugins like steal-bundler, steal-serviceworker and steal-electon that need the buildResult.

cc @matthewp @m-mujica any thought how we can do this?

[pYr0x]

@matthewp dont know whats that function is doing. if i comment it out, it worked for the multibuild, the slim build doesnt have one https://github.com/stealjs/steal-tools/pull/848/files#diff-b016b898f98b8eb1dc4d58c367f1bc38R99
is this.end() necessary?

[coveralls]

Coverage increased (+0.01%) to 92.679% when pulling 04d4207 on serviveworker into b923be1 on master.

[pYr0x]

the test does not pass because travis-ci runs steal-tools on node 4 and steal-serviceworker supports node 6+
@matthewp any possibility to drop support for node 4?
otherwise i have to transpile the serviceworker script to node 4

[matthewp]

We can't drop Node 4 until steal-tools 2.0. Looking at the build error: https://travis-ci.org/stealjs/steal-tools/jobs/279253395

I'm not sure it's a syntax problem... have you tried running it in Node 4 locally?

[pYr0x]

remove the integration of serviceworker because transpiling the source script to node 4 cause problems and i dont want to refactor steal-serviceworker.

this PR is still blocked by: stealjs/steal-bundler#30

[coveralls]

Coverage increased (+0.09%) to 92.758% when pulling 0d933cb on serviveworker into b923be1 on master.

[coveralls]

Coverage increased (+0.09%) to 92.758% when pulling 0d933cb on serviveworker into b923be1 on master.

[matthewp]

I'd rather not leave in commented out code... you never know when we'll be able to uncomment it out, so I think it's better to add it back when/if we are able to integrate steal-serviceworker.

[matthewp]

Same as above.

[coveralls]

Coverage increased (+0.09%) to 92.78% when pulling ceb089d on serviveworker into 0abee93 on master.