Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bundleAssets is not working with optimize build #846

Closed
1 of 5 tasks
matthewp opened this issue Sep 21, 2017 · 3 comments · Fixed by #848
Closed
1 of 5 tasks

bundleAssets is not working with optimize build #846

matthewp opened this issue Sep 21, 2017 · 3 comments · Fixed by #848

Comments

@matthewp
Copy link
Member

@pYr0x commented on Thu Sep 21 2017

How often can you reproduce it?

  • Always
  • Sometimes
  • Rarely
  • Unable
  • I didn’t try

Description:
bundleAssets is not working with optimize build

let buildResult = await stealTools.optimize({
        config: path.join(__dirname, "package.json!npm")
    }, {
        bundleAssets: {
            glob: [
                path.join(__dirname, "src", "assets", "**", "*"),
                path.join(__dirname, "src", "styles.css"),
                path.join(__dirname, "src", "manifest.json")
            ]
        },
        minify: true,
        bundlePromisePolyfill: false,
        splitLoader: true
    });

Expected results:
assets are copied

Actual results:
assets are not copied into the dist folder

Environment:

Software Version
Steal version latest
Steal-tools version latest
node -v 8
npm -v 5
Browser chrome
Operating system mac
@matthewp
Copy link
Member Author

Thanks, we probably just need to add it at the end like we did with the multibuild.

@pYr0x
Copy link
Contributor

pYr0x commented Sep 21, 2017

maybe tomorrow i can create a PR. i will see if it is that easy i think

@matthewp
Copy link
Member Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants