remove serviceworker integration until we drop node 4 support

stealjs · Sep 25, 2017 · 0d933cb · 0d933cb
1 parent e151814
commit 0d933cb
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 14 deletions.
diff --git a/lib/build/multi.js b/lib/build/multi.js
@@ -125,12 +125,15 @@ module.exports = function(config, options){
 						});
 					}
 
-					if(options.serviceWorker){
-						var precache = require("steal-serviceworker");
-						p = p.then(function (builtResult) {
-							return precache(builtResult, options.serviceWorker);
-						});
-					}
+					// steal-serviceworker can't be integrated until we drop support for node 4
+					// tests are written and ready
+					// maybe we come up with a better idea integrate post-build-plugins
+					// if(options.serviceWorker){
+					// 	var precache = require("steal-serviceworker");
+					// 	p = p.then(function (builtResult) {
+					// 		return precache(builtResult, options.serviceWorker);
+					// 	});
+					// }
 				}
 
 				p.then(function (builtResult) {

diff --git a/lib/build/slim.js b/lib/build/slim.js
@@ -106,12 +106,15 @@ module.exports = function(cfg, opts) {
 					});
 				}
 
-				if (options.serviceWorker) {
-					var precache = require("steal-serviceworker");
-					p = p.then(function (builtResult) {
-						return precache(builtResult, options.serviceWorker);
-					});
-				}
+				// steal-serviceworker can't be integrated until we drop support for node 4
+				// tests are written and ready
+				// maybe we come up with a better idea integrate post-build-plugins
+				// if(options.serviceWorker){
+				// 	var precache = require("steal-serviceworker");
+				// 	p = p.then(function (builtResult) {
+				// 		return precache(builtResult, options.serviceWorker);
+				// 	});
+				// }
 			}
 
 			p.then(function (builtResult) {

diff --git a/package.json b/package.json
@@ -29,7 +29,6 @@
     "steal": "^1.5.13",
     "steal-bundler": "^0.3.0",
     "steal-parse-amd": "^1.0.0",
-    "steal-serviceworker": "git://github.com/stealjs/steal-serviceworker.git#node4",
     "through2": "^2.0.0",
     "tmp": "0.0.33",
     "traceur": "0.0.111",

diff --git a/test/test.js b/test/test.js
@@ -52,4 +52,4 @@ require("./slim_loader_size_test");
 
 // external steal-tools plugins
 require("./bundle_assets_test");
-require("./serviceworker_test");
+//require("./serviceworker_test"); skip for now