Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract ContextItem#isTooLarge calculation and add deprecation note #4153

Merged
merged 1 commit into from May 14, 2024

Conversation

sqs
Copy link
Member

@sqs sqs commented May 11, 2024

There is no change to behavior; this is just a refactor to extract code, add some notes, and make other minor code style changes.

Test plan

CI

@sqs sqs requested a review from a team May 11, 2024 12:55
@sqs sqs changed the base branch from main to sqs/at-mention-spacebar May 11, 2024 12:57
There is no change to behavior; this is just a refactor.
Copy link
Member

@valerybugakov valerybugakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sqs sqs merged commit c6523a0 into sqs/at-mention-spacebar May 14, 2024
18 checks passed
@sqs sqs deleted the sqs/at-mention-ctx branch May 14, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants