Enterprise Cody Ignore: E2E test #4090
Conversation
|
@dominiccooney This PR is still missing some stuff and I wasn’t able to wrap it up but if you can get to it before I’m back, feel free to commandeer.
|
|
and cc @valerybugakov in case you have availability |
|
@valerybugakov @dominiccooney Took a quick look as to why the tests are failing. Turns out during the E2E test, we don't run in test or dev mode of the extension and thus the command we use to overwrite cody ignore doesn't seem to be working. I wonder if instead of using the overwrite command we shouldn't just mock the CodyIgnore API instead. Will try this out! |
|
@dominiccooney @valerybugakov Can I give you a friendly nudge to take a look at this? 🙂 |
| return INCLUDE_EVERYTHING_CONTEXT_FILTERS | ||
| } | ||
|
|
||
| const response = | ||
| await this.fetchSourcegraphAPI<APIResponse<ContextFiltersResponse | null>>( | ||
| CONTEXT_FILTERS_QUERY | ||
| ) | ||
| console.log({ response }) |
There was a problem hiding this comment.
Seems nice to log this with a bit more detail, since it only happens hourly.
There was a problem hiding this comment.
I think we're already logging the result of this in the context filter provider (so whenever we update the policy we'll see it in the debug logs). This was just me doing console.log debugging while figuring out how to mock these in the E2E test 😫
Co-authored-by: Dominic Cooney <dominic.cooney@sourcegraph.com>
This PR adds E2E tests for the cody ignore logic.
It currently does not test @-mention related behavior as well as the repo picker but since I’m focusing on the latecy issues, I thought it's better to get this test merged into main rather than waiting for the rest.
Test plan