Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Commands: Show context command errors in the notification message for easier debugging #3565

Merged
merged 3 commits into from Mar 27, 2024

Conversation

toolmantim
Copy link
Contributor

@toolmantim toolmantim commented Mar 26, 2024

If a custom command has problems running a context command, this adds the error output to the error notification, allowing you to more quickly debug the issue and try again.

Before After
CleanShot 2024-03-27 at 11 40 25@2x CleanShot 2024-03-27 at 11 39 37@2x
{
	"broken-command": {
	  "description": "Totes broken",
	  "prompt": "This aint gonna work",
	  "context": {
		"command": "command that doesnt work"
	  }
	}
}

Test plan

  • Manually tested

@toolmantim toolmantim changed the title Show the error message in the notification Show Custom Command errors in the notification message Mar 26, 2024
@toolmantim toolmantim marked this pull request as ready for review March 27, 2024 00:48
@toolmantim toolmantim requested a review from a team March 27, 2024 00:48
@toolmantim toolmantim changed the title Show Custom Command errors in the notification message Show custom command errors in the notification message for easier debugging Mar 27, 2024
@toolmantim toolmantim changed the title Show custom command errors in the notification message for easier debugging Custom Commands: show context command errors in the notification message for easier debugging Mar 27, 2024
@toolmantim toolmantim changed the title Custom Commands: show context command errors in the notification message for easier debugging Custom Commands: Show context command errors in the notification message for easier debugging Mar 27, 2024
@toolmantim toolmantim merged commit 5c22d71 into main Mar 27, 2024
23 checks passed
@toolmantim toolmantim deleted the tl+ch/show-custom-command-errors branch March 27, 2024 03:21
valerybugakov pushed a commit that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants