Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat: update at-mention input token color #3501

Merged
merged 2 commits into from Mar 22, 2024
Merged

Chat: update at-mention input token color #3501

merged 2 commits into from Mar 22, 2024

Conversation

abeatrix
Copy link
Contributor

Updates the color for the at-mention input tokens to make it more obvious to user. Right now it's hard to tell between a token and regular input.

Co-author with @toolmantim

Test plan

Before

image

After

image

Copy link
Contributor

@toolmantim toolmantim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! I checked themes, and the only thing I spotted was that light (high contrast) could do with a strong background color (maybe we just match the code style in the trascript, which is light text on very dark bg)

CleanShot 2024-03-22 at 13 17 10@2x

@abeatrix abeatrix merged commit 8a45976 into main Mar 22, 2024
18 checks passed
@abeatrix abeatrix deleted the bee/at-background branch March 22, 2024 05:09
@toolmantim
Copy link
Contributor

Turns out this doesn't work if things are broken between lines:

CleanShot 2024-03-26 at 00 37 54@2x

CleanShot 2024-03-26 at 00 37 43@2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants