Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit: Show warning on files that are too large #3494

Merged
merged 11 commits into from Mar 27, 2024
Merged

Edit: Show warning on files that are too large #3494

merged 11 commits into from Mar 27, 2024

Conversation

umpox
Copy link
Contributor

@umpox umpox commented Mar 21, 2024 •
edited

closes #2965

Description

This PR:

  • Adds a warning alongside large files that are @ mentioned in the Edit input
  • Shows open tabs by default in the Edit input, as soon as @ is triggered
image

Test plan

  1. Start an edit input, use @ mention
  2. Check open tabs are shown immediately
  3. Check a warning appears against a large file

@umpox umpox requested review from toolmantim, abeatrix and a team March 21, 2024 15:13
philipp-spiess
philipp-spiess approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@philipp-spiess philipp-spiess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice

abeatrix
abeatrix approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@abeatrix abeatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works smoothly! Left some comments inline.

I think some of the logics are duplicated and can be shared between chat and edit, we should work on that in a follow-up 😄

vscode/src/edit/input/constants.ts Outdated Show resolved Hide resolved
vscode/src/edit/input/get-matching-context.ts Outdated Show resolved Hide resolved
@abeatrix abeatrix mentioned this pull request Mar 21, 2024
Merged
@abeatrix
Copy link
Contributor

@umpox i just pushed my changes to this branch if you want to test it out :) #3498

image

@umpox
Copy link
Contributor Author

umpox commented Mar 22, 2024

@abeatrix Awesome, thank you.

I noticed a bug where symbol results don't show at all for edit or chat, when using @#. Looking into why 🤔

@abeatrix
Copy link
Contributor

@abeatrix Awesome, thank you.

I noticed a bug where symbol results don't show at all for edit or chat, when using @#. Looking into why 🤔

Ohhh do you think it's fixed in #3503?

@abeatrix
Copy link
Contributor

abeatrix commented Mar 22, 2024 •
edited

@abeatrix Awesome, thank you.
I noticed a bug where symbol results don't show at all for edit or chat, when using @#. Looking into why 🤔

Ohhh do you think it's fixed in #3503?

I pulled your branch and it's working for me for both Chat and Edit 👀

image

image

@umpox umpox enabled auto-merge (squash) March 27, 2024 10:15
@umpox umpox merged commit 0c756a5 into main Mar 27, 2024
19 of 20 checks passed
@umpox umpox deleted the tr/show-file-warning-edit branch March 27, 2024 10:17
valerybugakov pushed a commit that referenced this pull request Apr 22, 2024
@umpox @abeatrix @valerybugakov
Edit: Show warning on files that are too large (#3494)
023ced3 
Co-authored-by: Beatrix <68532117+abeatrix@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toolmantim toolmantim toolmantim approved these changes

@philipp-spiess philipp-spiess philipp-spiess approved these changes

@abeatrix abeatrix abeatrix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display warning for @-mentioning massive files
4 participants
@umpox @abeatrix @toolmantim @philipp-spiess