Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show "File too large" @-mention item warning on 2nd line in menu #3429

Merged
merged 1 commit into from Mar 16, 2024
Merged

show "File too large" @-mention item warning on 2nd line in menu #3429

merged 1 commit into from Mar 16, 2024

Conversation

sqs
Copy link
Member

@sqs sqs commented Mar 16, 2024 •
edited

Previously, this warning was shown on the same line. See the screenshots below. (Note that these are on different color themes, but you get the idea.)

After

image

Before

image

Test plan

CI

toolmantim
toolmantim approved these changes Mar 16, 2024
View reviewed changes
Copy link
Contributor

@toolmantim toolmantim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tbh I was torn on single line vs the extra line too. After testing it, what did you prefer?

@sqs
Copy link
Member Author

sqs commented Mar 16, 2024

Neither is great, but 2-line seems less broken in a “they fucked up the CSS” way.

@sqs sqs merged commit 7f4b68d into main Mar 16, 2024
18 checks passed
@sqs sqs deleted the sqs/rich-editor-misc branch March 16, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toolmantim toolmantim toolmantim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sqs @toolmantim