Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support link for Cody Pro & Enterprise #3330

Merged
merged 11 commits into from Mar 14, 2024

Conversation

toolmantim
Copy link
Contributor

@toolmantim toolmantim commented Mar 7, 2024

Adds Support to the sidebar and settings quickpick:

CleanShot 2024-03-07 at 12 40 16@2x

CleanShot 2024-03-07 at 12 40 23@2x

  • Fix Support to only show for Pro & Ent in quickpick

Test plan

  • Open sidebar on pro & ent plans. Click Support. Verify works.
  • Open settings quickpick on pro & ent plans. Click Support. Verify works.
  • Open sidebar on free plan. Verify no support link.
  • Open settings quickpick on free plan. Verify no support link.

@toolmantim
Copy link
Contributor Author

toolmantim commented Mar 7, 2024

@enriquegh it would be good to pre-fill the form with the current Cody for VS Code version automatically — is it possible to pass it URL params to https://help.sourcegraph.com/hc/en-us/requests/new? We could pass the version number and account ID, account type, etc.

@toolmantim
Copy link
Contributor Author

@abeatrix could I please get your assistance making the display of the quickpick item conditional, similar to how it works in the treeview?

@toolmantim
Copy link
Contributor Author

@abeatrix doh, I forget to check in the code that needed the conditionals! Fixed in d8b96dd

@abeatrix abeatrix force-pushed the tl/add-support-link-for-cody-pro branch from d8b96dd to 82b452f Compare March 7, 2024 07:33
@abeatrix
Copy link
Contributor

abeatrix commented Mar 7, 2024

@toolmantim pushed my changes to the branch 👍

@toolmantim toolmantim marked this pull request as ready for review March 7, 2024 09:14
@toolmantim toolmantim requested a review from a team March 7, 2024 09:14
Copy link
Contributor

@abeatrix abeatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

It would be nice to add a e2e test for this, but we can do it in a follow-up PR 🎉

vscode/src/services/tree-views/treeViewItems.ts Outdated Show resolved Hide resolved
@toolmantim
Copy link
Contributor Author

Added some e2e tests but something funky is going on with the unit tests now 🤔

@abeatrix
Copy link
Contributor

abeatrix commented Mar 7, 2024

Added some e2e tests but something funky is going on with the unit tests now 🤔

That's probably related to an issue @valerybugakov is working on

@valerybugakov
Copy link
Member

Yeah, unit tests should be fixed on main now 👍

@toolmantim
Copy link
Contributor Author

I think the changes in CurrentUserCodySubscription has meant the mock-server codyProEnabled flag is no longer applying properly. Do we need to mock out CurrentUserCodySubscription?

@toolmantim toolmantim merged commit d2e1186 into main Mar 14, 2024
16 checks passed
@toolmantim toolmantim deleted the tl/add-support-link-for-cody-pro branch March 14, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants