Add scheduled message support #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #743 +/- ##
=======================================
Coverage 93.97% 93.97%
=======================================
Files 7 7
Lines 448 448
Branches 43 43
=======================================
Hits 421 421
Misses 25 25
Partials 2 2
Continue to review full report at Codecov.
|
aoberoi
suggested changes
Mar 19, 2019
|
this looks p good p good. just one small correction for the plural-ness of the method arguments interface. |
Co-Authored-By: shanedewael <swdewael@gmail.com>
Co-Authored-By: shanedewael <swdewael@gmail.com>
|
Good call @aoberoi 🙇 |
aoberoi
approved these changes
Mar 19, 2019
aoberoi
added a commit
to aoberoi/node-slack-sdk
that referenced
this pull request
Mar 28, 2019
inpsired by slackapi#743
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds native support for
chat.scheduleMessage,chat.deleteScheduledMessageandchat.scheduledMessages.listAlso changes pcancelable to
~1.0.0because we don't want to use their types at the momentRequirements (place an
xin each[ ])