Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It turned out that the tests committed in #640 didn't actually test anything. The first tests conveniently had the assertion that mattered commented out, and the second test never returned the Promise, so the unhandled rejection was going unnoticed in our CI for quite some time.
The feature they meant to test does actually work. I only added one line to the implementation, and that was for clarity, not because the tests wouldn't pass without it.
Requirements (place an
x
in each[ ]
)