Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incoming webhook agent test #719

Merged
merged 3 commits into from Mar 7, 2019

Conversation

aoberoi
Copy link
Contributor

@aoberoi aoberoi commented Mar 7, 2019

Summary

It turned out that the tests committed in #640 didn't actually test anything. The first tests conveniently had the assertion that mattered commented out, and the second test never returned the Promise, so the unhandled rejection was going unnoticed in our CI for quite some time.

The feature they meant to test does actually work. I only added one line to the implementation, and that was for clarity, not because the tests wouldn't pass without it.

Requirements (place an x in each [ ])

@codecov
Copy link

codecov bot commented Mar 7, 2019

Codecov Report

Merging #719 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #719      +/-   ##
==========================================
+ Coverage   93.94%   93.95%   +0.01%     
==========================================
  Files           7        7              
  Lines         446      447       +1     
  Branches       43       43              
==========================================
+ Hits          419      420       +1     
  Misses         25       25              
  Partials        2        2
Impacted Files Coverage Δ
src/IncomingWebhook.ts 92.85% <100%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c640509...1813a8f. Read the comment docs.

@aoberoi aoberoi merged commit e62f4e5 into slackapi:master Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants