Skip to content

Commit

Permalink
Remove support-sinon.js as postinstall
Browse files Browse the repository at this point in the history 
We have managed to pay back outstanding expenses
  • Loading branch information
@mroderick
mroderick committed May 7, 2018
1 parent 374f593 commit 8f34417
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 20 deletions.
3 changes: 1 addition & 2 deletions package.json
View file
Expand Up @@ -32,8 +32,7 @@
"prebuild": "rimraf pkg && npm run check-dependencies",
"prepublishOnly": "npm run build",
"preversion": "./scripts/preversion.sh",
"postversion": "./scripts/postversion.sh",
"postinstall": "node scripts/support-sinon.js"
"postversion": "./scripts/postversion.sh"
},
"lint-staged": {
"*.js": "eslint",
Expand Down
18 changes: 0 additions & 18 deletions scripts/support-sinon.js
View file

This file was deleted.

1 comment on commit 8f34417

@vkarpov15
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for removing this. As a fellow OSS maintainer and someone who benefits from OpenCollective, I know how tempting it is to try to get the word out through every channel available. But more and more I think that npm install output isn't an appropriate place for this sort of message, especially in npm where people might see this message without depending on sinon directly like I did re: intercom/intercom-node#202.

Please sign in to comment.