Remove unused prop 'injectIntoThis'

Was not used anywhere in the code, except as setup in tests
sinonjs · Mar 12, 2019 · 73d2ac8 · 73d2ac8
1 parent fb5709f
commit 73d2ac8
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 10 deletions.
diff --git a/lib/sinon/util/core/default-config.js b/lib/sinon/util/core/default-config.js
@@ -1,7 +1,6 @@
 "use strict";
 
 module.exports = {
-    injectIntoThis: true,
     injectInto: null,
     properties: ["spy", "stub", "mock", "clock", "server", "requests"],
     useFakeTimers: true,

diff --git a/test/sandbox-test.js b/test/sandbox-test.js
@@ -1671,7 +1671,6 @@ describe("Sandbox", function() {
         it("yields stub, mock as arguments", function() {
             var sandbox = createSandbox(
                 sinonConfig({
-                    injectIntoThis: false,
                     properties: ["stub", "mock"]
                 })
             );
@@ -1686,7 +1685,6 @@ describe("Sandbox", function() {
         it("yields spy, stub, mock as arguments", function() {
             var sandbox = createSandbox(
                 sinonConfig({
-                    injectIntoThis: false,
                     properties: ["spy", "stub", "mock"]
                 })
             );
@@ -1701,7 +1699,6 @@ describe("Sandbox", function() {
         it("does not yield server when not faking xhr", function() {
             var sandbox = createSandbox(
                 sinonConfig({
-                    injectIntoThis: false,
                     properties: ["server", "stub", "mock"],
                     useFakeServer: false
                 })
@@ -1740,7 +1737,6 @@ describe("Sandbox", function() {
                 it("yields server when faking xhr", function() {
                     var sandbox = createSandbox(
                         sinonConfig({
-                            injectIntoThis: false,
                             properties: ["server", "stub", "mock"]
                         })
                     );
@@ -1756,7 +1752,6 @@ describe("Sandbox", function() {
                 it("uses serverWithClock when faking xhr", function() {
                     var sandbox = createSandbox(
                         sinonConfig({
-                            injectIntoThis: false,
                             properties: ["server"],
                             useFakeServer: fakeServerWithClock
                         })
@@ -1784,7 +1779,6 @@ describe("Sandbox", function() {
                 it("yields clock when faking timers", function() {
                     var sandbox = createSandbox(
                         sinonConfig({
-                            injectIntoThis: false,
                             properties: ["server", "clock"]
                         })
                     );
@@ -1846,7 +1840,6 @@ describe("Sandbox", function() {
         it("fakes specified timers", function() {
             var sandbox = createSandbox(
                 sinonConfig({
-                    injectIntoThis: false,
                     properties: ["clock"],
                     useFakeTimers: { toFake: ["Date", "setTimeout"] }
                 })

diff --git a/test/util/core/get-config-test.js b/test/util/core/get-config-test.js
@@ -12,7 +12,6 @@ describe("core/util/getConfig", function() {
             var config = getConfig();
 
             refute.same(config, defaultConfig);
-            assert.equals(config.injectIntoThis, defaultConfig.injectIntoThis);
             assert.equals(config.injectInto, defaultConfig.injectInto);
             assert.equals(config.properties, defaultConfig.properties);
             assert.equals(config.useFakeTimers, defaultConfig.useFakeTimers);
@@ -26,7 +25,6 @@ describe("core/util/getConfig", function() {
             });
 
             refute.same(config, defaultConfig);
-            assert.equals(config.injectIntoThis, defaultConfig.injectIntoThis);
             assert.equals(config.injectInto, defaultConfig.injectInto);
             assert.equals(config.properties, ["stub", "mock"]);
             assert.equals(config.useFakeTimers, defaultConfig.useFakeTimers);