[fix] sandbox.restore handles protype props

sinonjs · Mar 9, 2020 · 4b55c62 · 4b55c62
1 parent aac0bc3
commit 4b55c62
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/lib/sinon/sandbox.js b/lib/sinon/sandbox.js
@@ -189,9 +189,14 @@ function Sandbox() {
 
     function getFakeRestorer(object, property) {
         var descriptor = getPropertyDescriptor(object, property);
+        var shadowsPrototypeProp = typeof Object.getOwnPropertyDescriptor(object, property) === "undefined";
 
         function restorer() {
-            Object.defineProperty(object, property, descriptor);
+            if (!shadowsPrototypeProp) {
+                Object.defineProperty(object, property, descriptor);
+            } else {
+                delete object[property];
+            }
         }
         restorer.object = object;
         restorer.property = property;