Fix 1445: make stubbing of static function properties possible

sinonjs · Jun 6, 2017 · 452981c · 452981c
1 parent 25f3eeb
commit 452981c
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/lib/sinon/stub.js b/lib/sinon/stub.js
@@ -18,7 +18,7 @@ function stub(object, property, descriptor) {
     var isStubbingEntireObject = typeof property === "undefined" && typeof object === "object";
     var isCreatingNewStub = !object && typeof property === "undefined";
     var isStubbingDescriptor = object && property && Boolean(descriptor);
-    var isStubbingNonFuncProperty = typeof object === "object"
+    var isStubbingNonFuncProperty = (typeof object === "object" || typeof object === "function")
                                     && typeof property !== "undefined"
                                     && (typeof actualDescriptor === "undefined"
                                     || typeof actualDescriptor.value !== "function")

diff --git a/test/stub-test.js b/test/stub-test.js
@@ -2654,5 +2654,23 @@ describe("stub", function () {
 
             assert.equals(getPropertyDescriptor(obj, "nonExisting"), undefined);
         });
+
+        it("allows stubbing function static properties", function () {
+            var myFunc = function () {};
+            myFunc.prop = "rawString";
+
+            createStub(myFunc, "prop").value("newString");
+            assert.equals(myFunc.prop, "newString");
+        });
+
+        it("allows restoring function static properties", function () {
+            var myFunc = function () {};
+            myFunc.prop = "rawString";
+
+            var stub = createStub(myFunc, "prop").value("newString");
+            stub.restore();
+
+            assert.equals(myFunc.prop, "rawString");
+        });
     });
 });