added more details and notes

sinonjs · Dec 19, 2017 · 360c2e7 · 360c2e7
1 parent 4fd01ef
commit 360c2e7
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -28,6 +28,7 @@ jobs:
                 npm install
               fi
 
+              # install latest chrome unstable version
               if node --version | grep -q '^v6'; then
                 wget -q -O - https://dl-ssl.google.com/linux/linux_signing_key.pub | apt-key add -
                 echo "deb [arch=amd64] http://dl.google.com/linux/chrome/deb/ stable main" >> /etc/apt/sources.list.d/google.list
@@ -40,7 +41,9 @@ jobs:
           command: |
               if node --version | grep -q '^v6'; then
                 npm run lint;
-                # modify mochify to pass additional params to chrome
+                # HACK: modify mochify to pass args to chrome to allow it to run as root
+                #   --no-sandbox --disable-setuid-sandbox
+                # See https://github.com/mantoni/mochify.js/issues/162
                 sed -i "s#'--allow-insecure-localhost'#'--allow-insecure-localhost', '--no-sandbox', '--disable-setuid-sandbox'#" node_modules/mochify/lib/chromium.js && echo "modified mochify/lib/chromium.js";
                 npm run test-headless -- --chrome $(which google-chrome-unstable);
                 npm run test-webworker -- --chrome $(which google-chrome-unstable);
@@ -57,8 +60,6 @@ jobs:
     <<: *common-build
     docker:
       - image: node:4
-    environment:
-        PUPPETEER_SKIP_CHROMIUM_DOWNLOAD: true
 
   node-6:
     <<: *common-build