Skip to content

Commit

Permalink
Add requirements to pull request template
Browse files Browse the repository at this point in the history
  • Loading branch information
fatso83 committed Aug 10, 2017
1 parent 56ca580 commit 052a2d0
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions .github/PULL_REQUEST_TEMPLATE.md
Expand Up @@ -13,11 +13,16 @@
#### Solution - optional
> When contributing code (and not just fixing typos, documentation and configuration), please describe why/how your solution works. This helps reviewers spot any mistakes in the implementation.
>
> Example:
> Example:
> "This solution works by adding a `paintBlue()` method"
> Then your reviewer might spot a mistake in the implementation, if `paintBlue()` uses the colour red.
#### How to verify - mandatory
1. Check out this branch (see github instructions below)
1. Check out this branch
2. `npm install`
3. <your-steps-here>

#### Checklist for author

- [ ] `npm run lint` passes
- [ ] References to standard library functions are [cached](https://github.com/sinonjs/sinon/pull/1523).

0 comments on commit 052a2d0

Please sign in to comment.