Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checking collaborators when publishing to external registry #491

Merged
merged 1 commit into from Jan 25, 2020
Merged

Fix checking collaborators when publishing to external registry #491

merged 1 commit into from Jan 25, 2020

Conversation

fohletex
Copy link
Contributor

I experienced issues when working with np and referencing an external registry. Although I added

"publishConfig": {
    "registry": "https://fooregistry.tld"
 },

to my package.json file and having an additional reference in the local .npmrc-file, the check prerequisities command required a long time and finally failed. As #339 states an npm update might help, but my version was already 6.13.1.

The reason for my issue was that the npm.collaborators-command missed an additional arg option "--registry https://fooregistry.tld": This PR adds the required option and thus fixes the npm.collaborators-command in order to allow collaborator checks for external registries.

Although these issues are already closed, the error I experienced with the most-current np version comes closest to those:

Copy link
Collaborator

@itaisteinherz itaisteinherz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @fohletex!

@itaisteinherz itaisteinherz changed the title Fixed issue of executing collaborator command for external registries Fix checking collaborators when publishing to external registry Jan 25, 2020
@itaisteinherz itaisteinherz merged commit 4ad4146 into sindresorhus:master Jan 25, 2020
@fohletex fohletex deleted the fix-external-registries branch January 28, 2020 14:16
@fohletex fohletex restored the fix-external-registries branch January 28, 2020 14:19
@fohletex
Copy link
Contributor Author

You are welcome! Thanks for merging. :)

@fohletex fohletex deleted the fix-external-registries branch January 28, 2020 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command failed: npm access ls-collaborators X Prerequisite check runs forever
2 participants