New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow publishing if availability check fails #490
Merged
itaisteinherz
merged 4 commits into
sindresorhus:master
from
terenceodonoghue:fix/check-availability
Feb 6, 2020
Merged
Allow publishing if availability check fails #490
itaisteinherz
merged 4 commits into
sindresorhus:master
from
terenceodonoghue:fix/check-availability
Feb 6, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ready to merge? |
@EronWright not just yet; just need to fix PR per @itaisteinherz 's feedback then we'll see. |
itaisteinherz
approved these changes
Feb 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@terenceodonoghue Thanks for working on this! 😄
itaisteinherz
changed the title
Allow publish if availability check fails
Allow publishing if availability check fails
Feb 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #489
Before:
After:
Adds an additional check whereby if a package's availability cannot be determined, it will prompt to attempt the publish anyway.