Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow publishing if availability check fails #490

Merged
merged 4 commits into from Feb 6, 2020
Merged

Allow publishing if availability check fails #490

merged 4 commits into from Feb 6, 2020

Conversation

terenceodonoghue
Copy link
Contributor

@terenceodonoghue terenceodonoghue commented Jan 20, 2020

Fixes #489

Before:

Screen Shot 2020-01-20 at 8 32 02 pm

After:

Screen Shot 2020-01-20 at 8 34 42 pm

Adds an additional check whereby if a package's availability cannot be determined, it will prompt to attempt the publish anyway.

source/ui.js Outdated Show resolved Hide resolved
source/cli.js Outdated Show resolved Hide resolved
source/ui.js Outdated Show resolved Hide resolved
source/ui.js Outdated Show resolved Hide resolved
source/cli.js Outdated Show resolved Hide resolved
source/cli.js Outdated Show resolved Hide resolved
@EronWright
Copy link

Ready to merge?

@terenceodonoghue
Copy link
Contributor Author

@EronWright not just yet; just need to fix PR per @itaisteinherz 's feedback then we'll see.

Copy link
Collaborator

@itaisteinherz itaisteinherz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@terenceodonoghue Thanks for working on this! 😄

@itaisteinherz itaisteinherz changed the title Allow publish if availability check fails Allow publishing if availability check fails Feb 6, 2020
@itaisteinherz itaisteinherz merged commit ccdb8a5 into sindresorhus:master Feb 6, 2020
@terenceodonoghue terenceodonoghue deleted the fix/check-availability branch February 6, 2020 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publishing to GitHub Packages yields 405 (Method Not Allowed)
3 participants